Use RequiresReplaceIfConfigured in place of RequiresReplace for Optional+Computed+ForceNew attributes

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
• The resources and data sources in this provider are generated from the CloudFormation schema, so they can only support the actions that the underlying schema supports. For this reason submitted bugs should be limited to defects in the generation and runtime code of the provider. Customizing behavior of the resource, or noting a gap in behavior are not valid bugs and should be submitted as enhancements to AWS via the CloudFormation Open Coverage Roadmap.

Use RequiresReplaceIfConfigured in place of RequiresReplace for Optional+Computed+ForceNew attributes. The prevents resource replacement when no attribute value has been configured (and hence the planned value is Unknown) but there is a value in state.

Closes #1713.
Closes #1139.
Closes #1690.
Relates #222.
Relates #306.
Relates hashicorp/terraform-plugin-framework#187.
Relates hashicorp/terraform-plugin-framework#189.
Relates hashicorp/terraform-plugin-framework#213.
Relates hashicorp/terraform-plugin-framework#565.

% TF_LOG=ERROR make testacc PKG_NAME=internal/aws/logs TESTARGS='-run=TestAccAWSLogsLogGroup_\|TestAccAWSLogsLogGroupDataSource_' ACCTEST_PARALLELISM=3
TF_ACC=1 go test ./internal/aws/logs -v -count 1 -parallel 3 -run=TestAccAWSLogsLogGroup_\|TestAccAWSLogsLogGroupDataSource_ -timeout 180m
=== RUN   TestAccAWSLogsLogGroup_basic
=== PAUSE TestAccAWSLogsLogGroup_basic
=== RUN   TestAccAWSLogsLogGroup_disappears
=== PAUSE TestAccAWSLogsLogGroup_disappears
=== RUN   TestAccAWSLogsLogGroup_update
=== PAUSE TestAccAWSLogsLogGroup_update
=== RUN   TestAccAWSLogsLogGroupDataSource_basic
=== PAUSE TestAccAWSLogsLogGroupDataSource_basic
=== RUN   TestAccAWSLogsLogGroupDataSource_NonExistent
=== PAUSE TestAccAWSLogsLogGroupDataSource_NonExistent
=== CONT  TestAccAWSLogsLogGroup_basic
=== CONT  TestAccAWSLogsLogGroupDataSource_basic
=== CONT  TestAccAWSLogsLogGroup_update
--- PASS: TestAccAWSLogsLogGroup_basic (25.66s)
=== CONT  TestAccAWSLogsLogGroupDataSource_NonExistent
--- PASS: TestAccAWSLogsLogGroupDataSource_NonExistent (1.82s)
=== CONT  TestAccAWSLogsLogGroup_disappears
--- PASS: TestAccAWSLogsLogGroupDataSource_basic (27.85s)
--- PASS: TestAccAWSLogsLogGroup_update (40.07s)
--- PASS: TestAccAWSLogsLogGroup_disappears (29.64s)
PASS
ok  	github.com/hashicorp/terraform-provider-awscc/internal/aws/logs	57.954s

% TF_LOG=ERROR make testacc PKG_NAME=internal/aws/ec2 TESTARGS='-run=TestAccAWSEC2IPAMPool_update'
TF_ACC=1 go test ./internal/aws/ec2 -v -count 1 -parallel 20 -run=TestAccAWSEC2IPAMPool_update -timeout 180m
=== RUN   TestAccAWSEC2IPAMPool_update
=== PAUSE TestAccAWSEC2IPAMPool_update
=== CONT  TestAccAWSEC2IPAMPool_update
--- PASS: TestAccAWSEC2IPAMPool_update (141.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-awscc/internal/aws/ec2	142.101s

[wellsiau-aws]

Tracking the feature request at #1713 for historical purpose.