Merge pull request #979 from hashicorp/bugfix/group-mailnickname-period

azuread_group: mail_nickname can contain a period (.)
hashicorp · Jan 19, 2023 · 3029da1 · 3029da1
2 parents ddee84a + b02aaf1
commit 3029da1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/internal/services/groups/group_resource_test.go b/internal/services/groups/group_resource_test.go
@@ -502,7 +502,7 @@ resource "azuread_group" "test" {
   description      = "Please delete me as this is a.test.AD group!"
   types            = ["Unified"]
   mail_enabled     = true
-  mail_nickname    = "acctestGroup-%[1]d"
+  mail_nickname    = "acctest.Group-%[1]d"
   security_enabled = true
   theme            = "Pink"
 }
@@ -532,7 +532,7 @@ resource "azuread_group" "test" {
   description      = "Please delete me as this is a.test.AD group!"
   types            = ["Unified"]
   mail_enabled     = true
-  mail_nickname    = "acctestGroup-%[1]d"
+  mail_nickname    = "acctest.Group-%[1]d"
   security_enabled = true
   theme            = "Pink"
 
@@ -563,7 +563,7 @@ resource "azuread_group" "test" {
   display_name     = "acctestGroup-complete-%[1]d"
   types            = ["Unified"]
   mail_enabled     = true
-  mail_nickname    = "acctestGroup-%[1]d"
+  mail_nickname    = "acctest.Group-%[1]d"
   security_enabled = true
   members          = [azuread_user.test.object_id]
   owners           = [azuread_user.test.object_id]
@@ -607,7 +607,7 @@ resource "azuread_group" "test" {
   description      = "Please delete me as this is a.test.AD group!"
   types            = ["DynamicMembership", "Unified"]
   mail_enabled     = true
-  mail_nickname    = "acctestGroup-%[1]d"
+  mail_nickname    = "acctest.Group-%[1]d"
   security_enabled = true
 
   dynamic_membership {

diff --git a/internal/validate/mail.go b/internal/validate/mail.go
@@ -18,10 +18,10 @@ func MailNickname(i interface{}, path cty.Path) (ret diag.Diagnostics) {
 		return
 	}
 
-	if regexp.MustCompile(`[@()\\\[\]";:.<>, ]`).MatchString(v) {
+	if regexp.MustCompile(`[@()\\\[\]";:<>, ]`).MatchString(v) {
 		ret = append(ret, diag.Diagnostic{
 			Severity:      diag.Error,
-			Summary:       "Value cannot contain these characters: @()\\[]\";:.<>,SPACE",
+			Summary:       "Value cannot contain these characters: @()\\[]\";:<>,SPACE",
 			AttributePath: path,
 		})
 	}