Fix for Issue #843 - end_date_relative for application_password #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manicminer
approved these changes
Aug 5, 2022
|
Test results
|
|
This functionality has been released in v2.27.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Threpio
pushed a commit
to Threpio/terraform-provider-azuread
that referenced
this pull request
Aug 5, 2022
manicminer
added a commit
to Threpio/terraform-provider-azuread
that referenced
this pull request
Aug 25, 2022
manicminer
pushed a commit
to Threpio/terraform-provider-azuread
that referenced
this pull request
Aug 25, 2022
…ord (hashicorp#844) * Simple fix for end_date_relative bug * Testing locally + logic * There is no reason these two functions should be this different
manicminer
added a commit
that referenced
this pull request
Aug 25, 2022
* Initial DataSource file created * Update location * Switch Case added for some types * Basic docs, removed linter problem and added client * Run tflint * Forgetting that it has to define the provider in the datasource registration * Adding the Registration function * Assign data to state correctly * Update docs/data-sources/principal_type.md Additional Interpolation removed Co-authored-by: Tom Bamford <tom@bamford.io> * Update internal/services/directoryobjects/principal_type_data_source.go Imports tidied up Co-authored-by: Tom Bamford <tom@bamford.io> * Update docs/data-sources/principal_type.md Wording as per suggestion Co-authored-by: Tom Bamford <tom@bamford.io> * Updated as per other comments * Removed redundant type for this data_source * Import fmt and tests * Fixing Tests + Documents * Accidentally wrote the docs twice?? * Test config fixes, use provider context * Rename data source, add missing nil checking * TC config for directoryobjects package * Docs to reflect renamed data source * Docs wording for azuread_directory_object data source * Update application_password.md * Changelog for #844 * Fix for Issue #843 - end_date_relative for application_password (#844) * Simple fix for end_date_relative bug * Testing locally + logic * There is no reason these two functions should be this different * v2.27.0 * Add warning that OIDC auth only works in GitHub Actions * Update docs/guides/service_principal_oidc.md * Update to Go 1.19 * Remove tfproviderlint * Docs: azuread_group.dynamic_membership.rule is required, not optional. Fixes #857 Co-authored-by: Tom Bamford <tom@bamford.io> Co-authored-by: Sam Gladstone <42203151+samgladstone@users.noreply.github.com>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the suggestions and comparisons with the power-shell in the issue itself.
Issue link: #843