Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In azuread_group rule parameter of 'dynamic membership' block is required but in terraform documentation it is marked as 'Optional' #857

Closed
MayuriD89 opened this issue Aug 3, 2022 · 2 comments · Fixed by #858
Closed

In azuread_group rule parameter of 'dynamic membership' block is required but in terraform documentation it is marked as 'Optional' #857

MayuriD89 opened this issue Aug 3, 2022 · 2 comments · Fixed by #858
Labels
documentation feature/groups

Comments

@MayuriD89
Copy link

MayuriD89 commented Aug 3, 2022 •
edited
Loading

Terraform (and AzureAD Provider) Version

  • Terraform v1.0.0
  • Azuread Plugin Version v2.20.0

Affected Resource

  • azuread_group

Expected Behavior

  • azuread_group resource should get successfully created even if rule parameter from 'Dynamic membership' block is not specified.

Actual Behavior

  • terraform throws following error if 'rule' parameter is not specified -

image

  • Seems like terraform documentation provides a wrong information 'rule' parameter is 'Required' and this should be updated in future releases.

Steps to Reproduce

  • terraform plan
  • terraform apply
@manicminer
Copy link
Contributor

Thanks for the report @MayuriD89. We'll look to fix this in the docs.

@manicminer manicminer mentioned this issue Aug 5, 2022
Merged
manicminer added a commit that referenced this issue Aug 25, 2022
@manicminer
Docs: azuread_group.dynamic_membership.rule is required, not optional. …
4c307f2 
…Fixes #857
manicminer added a commit to Threpio/terraform-provider-azuread that referenced this issue Aug 25, 2022
@manicminer
Docs: azuread_group.dynamic_membership.rule is required, not optional. …
1c1d868 
…Fixes hashicorp#857
manicminer added a commit that referenced this issue Aug 25, 2022
@Threpio @manicminer @samgladstone
New data source: azuread_directory_object (#847)
1381ad4 
* Initial DataSource file created

* Update location

* Switch Case added for some types

* Basic docs, removed linter problem and added client

* Run tflint

* Forgetting that it has to define the provider in the datasource registration

* Adding the Registration function

* Assign data to state correctly

* Update docs/data-sources/principal_type.md

Additional Interpolation removed

Co-authored-by: Tom Bamford <tom@bamford.io>

* Update internal/services/directoryobjects/principal_type_data_source.go

Imports tidied up

Co-authored-by: Tom Bamford <tom@bamford.io>

* Update docs/data-sources/principal_type.md

Wording as per suggestion

Co-authored-by: Tom Bamford <tom@bamford.io>

* Updated as per other comments

* Removed redundant type for this data_source

* Import fmt and tests

* Fixing Tests + Documents

* Accidentally wrote the docs twice??

* Test config fixes, use provider context

* Rename data source, add missing nil checking

* TC config for directoryobjects package

* Docs to reflect renamed data source

* Docs wording for azuread_directory_object data source

* Update application_password.md

* Changelog for #844

* Fix for Issue #843 - end_date_relative for application_password (#844)

* Simple fix for end_date_relative bug

* Testing locally + logic

* There is no reason these two functions should be this different

* v2.27.0

* Add warning that OIDC auth only works in GitHub Actions

* Update docs/guides/service_principal_oidc.md

* Update to Go 1.19

* Remove tfproviderlint

* Docs: azuread_group.dynamic_membership.rule is required, not optional. Fixes #857

Co-authored-by: Tom Bamford <tom@bamford.io>
Co-authored-by: Sam Gladstone <42203151+samgladstone@users.noreply.github.com>
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
documentation feature/groups
Projects
None yet
Milestone
No milestone
2 participants
@manicminer @MayuriD89