Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: azuread_access_package_assignment_policy fails with alternative_approver #1567

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: azuread_access_package_assignment_policy fails with alternative_approver #1567

wants to merge 1 commit into from
+3 −3

Conversation

pauliusmiskinis
Copy link

@pauliusmiskinis pauliusmiskinis commented Nov 12, 2024 •
edited
Loading

Potential fix for #1535

@pauliusmiskinis pauliusmiskinis requested review from katbyte and a team as code owners November 12, 2024 21:28
@kristeey
Copy link

Can someone review this plz 🙏

@aaron-warner-nzta
Copy link

aaron-warner-nzta commented Dec 15, 2024 •
edited
Loading

I hit the issue and have tested this fix locally. It resolved the issue.
Before fix you get a 400 error with null argument errors. With this fix it will create the alternate approver settings against the policy correctly.

It would be good to get this in for 3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katbyte katbyte Awaiting requested review from katbyte

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature/identity-governance size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pauliusmiskinis @kristeey @aaron-warner-nzta