Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_application: Allow app_role.id to be specified manually #254

Closed
wants to merge 5 commits into from

Conversation

manicminer
Copy link
Contributor

Allow azuread_application.app_role.id to be specified manually. This is an accepted use case since the API permits it, and is required for some advanced scenarios where UUIDs are carefully coordinated.

Fixes #150

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks @manicminer

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too 👍

@katbyte katbyte added this to the v0.10.0 milestone May 24, 2020
@manicminer
Copy link
Contributor Author

Hitting some seesawing test failures on this, will update when resolved.

@manicminer manicminer changed the title Allow azuread_application.app_role.id to be specified manually azuread_application: Allow app_role.id to be specified manually May 27, 2020
@ghost ghost added size/M and removed size/S labels May 28, 2020
@manicminer manicminer marked this pull request as draft May 30, 2020 22:01
@manicminer manicminer modified the milestones: v0.10.0, v0.11.0 Jun 5, 2020
@manicminer
Copy link
Contributor Author

Closing in favor of #298

@manicminer manicminer closed this Aug 20, 2020
@ghost
Copy link

ghost commented Sep 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 19, 2020
@manicminer manicminer deleted the app/app-role-id branch December 14, 2020 02:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azuread_application: app_role id can't be specified manually
3 participants