Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_application: avoid update after create #367

Merged
merged 2 commits into from
Nov 26, 2020
Merged

azuread_application: avoid update after create #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f7e80f
azuread_application: avoid update during create, move app roles and o…
manicminer Nov 26, 2020
96e713d
azuread_application: correctly set prevent_duplicate_names on read to…
manicminer Nov 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
231 changes: 106 additions & 125 deletions internal/services/aadgraph/application_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,10 @@ func applicationResource() *schema.Resource {
},

"app_role": {
Type: schema.TypeSet,
Optional: true,
Computed: true,
Type: schema.TypeSet,
Optional: true,
Computed: true,
ConfigMode: schema.SchemaConfigModeAttr,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"id": {
Expand Down Expand Up @@ -158,6 +159,67 @@ func applicationResource() *schema.Resource {
},
},

"oauth2_permissions": {
Type: schema.TypeSet,
Optional: true,
Computed: true,
ConfigMode: schema.SchemaConfigModeAttr,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"admin_consent_description": {
Type: schema.TypeString,
Optional: true,
Computed: true,
ValidateFunc: validate.NoEmptyStrings,
},

"admin_consent_display_name": {
Type: schema.TypeString,
Optional: true,
Computed: true,
ValidateFunc: validate.NoEmptyStrings,
},

"id": {
Type: schema.TypeString,
Computed: true,
},

"is_enabled": {
Type: schema.TypeBool,
Optional: true,
Computed: true,
},

"type": {
Type: schema.TypeString,
Optional: true,
Computed: true,
ValidateFunc: validation.StringInSlice([]string{"Admin", "User"}, false),
},

"user_consent_description": {
Type: schema.TypeString,
Optional: true,
Computed: true,
},

"user_consent_display_name": {
Type: schema.TypeString,
Optional: true,
Computed: true,
},

"value": {
Type: schema.TypeString,
Optional: true,
Computed: true,
ValidateFunc: validate.NoEmptyStrings,
},
},
},
},

"optional_claims": {
Type: schema.TypeList,
Optional: true,
Expand Down Expand Up @@ -228,67 +290,6 @@ func applicationResource() *schema.Resource {
Computed: true,
},

"oauth2_permissions": {
Type: schema.TypeSet,
Optional: true,
Computed: true,
ConfigMode: schema.SchemaConfigModeAttr,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"admin_consent_description": {
Type: schema.TypeString,
Optional: true,
Computed: true,
ValidateFunc: validate.NoEmptyStrings,
},

"admin_consent_display_name": {
Type: schema.TypeString,
Optional: true,
Computed: true,
ValidateFunc: validate.NoEmptyStrings,
},

"id": {
Type: schema.TypeString,
Computed: true,
},

"is_enabled": {
Type: schema.TypeBool,
Optional: true,
Computed: true,
},

"type": {
Type: schema.TypeString,
Optional: true,
Computed: true,
ValidateFunc: validation.StringInSlice([]string{"Admin", "User"}, false),
},

"user_consent_description": {
Type: schema.TypeString,
Optional: true,
Computed: true,
},

"user_consent_display_name": {
Type: schema.TypeString,
Optional: true,
Computed: true,
},

"value": {
Type: schema.TypeString,
Optional: true,
Computed: true,
ValidateFunc: validate.NoEmptyStrings,
},
},
},
},

"prevent_duplicate_names": {
Type: schema.TypeBool,
Optional: true,
Expand Down Expand Up @@ -402,6 +403,24 @@ func applicationResourceCreate(d *schema.ResourceData, meta interface{}) error {
}
}

if v, ok := d.GetOk("app_role"); ok {
appRoles := expandApplicationAppRoles(v)
if appRoles != nil {
if err := graph.AppRolesSet(ctx, client, *app.ObjectID, appRoles); err != nil {
return err
}
}
}

if v, ok := d.GetOk("oauth2_permissions"); ok {
oauth2Permissions := expandApplicationOAuth2Permissions(v)
if oauth2Permissions != nil {
if err := graph.OAuth2PermissionsSet(ctx, client, *app.ObjectID, oauth2Permissions); err != nil {
return err
}
}
}

// there is a default owner that we must account so use this shared function
if v, ok := d.GetOk("owners"); ok {
desiredOwners := *tf.ExpandStringSlicePtr(v.(*schema.Set).List())
Expand All @@ -410,9 +429,7 @@ func applicationResourceCreate(d *schema.ResourceData, meta interface{}) error {
}
}

// After creating the application, we immediately update it to ensure we overwrite any default properties
// such as the `user_impersonation` scope the application may get, whether we define such a scope or not
return applicationResourceUpdate(d, meta)
return applicationResourceRead(d, meta)
}

func applicationResourceUpdate(d *schema.ResourceData, meta interface{}) error {
Expand Down Expand Up @@ -474,58 +491,6 @@ func applicationResourceUpdate(d *schema.ResourceData, meta interface{}) error {
properties.OptionalClaims = expandApplicationOptionalClaims(d)
}

if d.HasChange("oauth2_permissions") {
// if the permission already exists then it must be disabled
// with no other changes before it can be edited or deleted
var app graphrbac.Application
var appProperties graphrbac.ApplicationUpdateParameters
resp, err := client.Get(ctx, d.Id())
if err != nil {
if utils.ResponseWasNotFound(resp.Response) {
return fmt.Errorf("Application with ID %q was not found", d.Id())
}

return fmt.Errorf("retrieving Application with ID %q: %+v", d.Id(), err)
}
app = resp
for _, OAuth2Permission := range *app.Oauth2Permissions {
*OAuth2Permission.IsEnabled = false
}
appProperties.Oauth2Permissions = app.Oauth2Permissions
if _, err := client.Patch(ctx, d.Id(), appProperties); err != nil {
return fmt.Errorf("disabling OAuth2 permissions for Application with ID %q: %+v", d.Id(), err)
}

// now we can set the new state of the permission
properties.Oauth2Permissions = expandApplicationOAuth2Permissions(d.Get("oauth2_permissions"))
}

if d.HasChange("app_role") {
// if the app role already exists then it must be disabled
// with no other changes before it can be edited or deleted
var app graphrbac.Application
var appRolesProperties graphrbac.ApplicationUpdateParameters
resp, err := client.Get(ctx, d.Id())
if err != nil {
if utils.ResponseWasNotFound(resp.Response) {
return fmt.Errorf("Application with ID %q was not found", d.Id())
}

return fmt.Errorf("retrieving Application with ID %q: %+v", d.Id(), err)
}
app = resp
for _, appRole := range *app.AppRoles {
*appRole.IsEnabled = false
}
appRolesProperties.AppRoles = app.AppRoles
if _, err := client.Patch(ctx, d.Id(), appRolesProperties); err != nil {
return fmt.Errorf("disabling App Roles for Application with ID %q: %+v", d.Id(), err)
}

// now we can set the new state of the app role
properties.AppRoles = expandApplicationAppRoles(d.Get("app_role"))
}

if d.HasChange("group_membership_claims") {
properties.GroupMembershipClaims = graphrbac.GroupMembershipClaimTypes(d.Get("group_membership_claims").(string))
}
Expand All @@ -547,6 +512,23 @@ func applicationResourceUpdate(d *schema.ResourceData, meta interface{}) error {
return fmt.Errorf("patching Application with ID %q: %+v", d.Id(), err)
}

if d.HasChange("app_role") {
appRoles := expandApplicationAppRoles(d.Get("app_role"))
if appRoles != nil {
if err := graph.AppRolesSet(ctx, client, d.Id(), appRoles); err != nil {
return err
}
}
}

if d.HasChange("oauth2_permissions") {
oauth2Permissions := expandApplicationOAuth2Permissions(d.Get("oauth2_permissions"))
if oauth2Permissions != nil {
if err := graph.OAuth2PermissionsSet(ctx, client, d.Id(), oauth2Permissions); err != nil {
return err
}
}
}
if v, ok := d.GetOkExists("owners"); ok && d.HasChange("owners") {
desiredOwners := *tf.ExpandStringSlicePtr(v.(*schema.Set).List())
if err := applicationSetOwnersTo(ctx, client, d.Id(), desiredOwners); err != nil {
Expand Down Expand Up @@ -623,9 +605,11 @@ func applicationResourceRead(d *schema.ResourceData, meta interface{}) error {
return fmt.Errorf("setting `owners`: %+v", err)
}

if preventDuplicates := d.Get("prevent_duplicate_names").(bool); !preventDuplicates {
d.Set("prevent_duplicate_names", false)
preventDuplicates := false
if v := d.Get("prevent_duplicate_names").(bool); v {
preventDuplicates = v
}
d.Set("prevent_duplicate_names", preventDuplicates)

return nil
}
Expand Down Expand Up @@ -837,11 +821,8 @@ func flattenApplicationOptionalClaimsList(in *[]graphrbac.OptionalClaim) []inter

func expandApplicationAppRoles(i interface{}) *[]graphrbac.AppRole {
input := i.(*schema.Set).List()
if len(input) == 0 {
return nil
}

output := make([]graphrbac.AppRole, 0, len(input))

for _, appRoleRaw := range input {
appRole := appRoleRaw.(map[string]interface{})

Expand Down
Loading