Feature Request: Support Storage Account Firewall and Network Rules

[HighwayofLife]

Feature Request: Add support for Storage Account Firewall and Network Rules.

Affected Resource(s)

• azurerm_storage_account
• azurerm_subnet

Subnets need to be able to create service endpoints. (see below ARM snippet)

References

• Announcement: Virtual Network Integration for Azure Storage and Azure SQL
• Configure Storage Network Security
• Virtual Network Service Endpoints

ARM Template snippet - Storage

"kind": "Storage",
"name": "[parameters('storageAccounts_devworkdiag410_name')]",
"apiVersion": "2017-10-01",
"location": "eastus2",
"tags": {},
"scale": null,
"properties": {
    "networkAcls": {
        "bypass": "AzureServices",
        "virtualNetworkRules": [
            {
                "id": "[resourceId('Microsoft.Network/virtualNetworks/subnets', parameters('virtualNetworks_DevWork_vnet_name'), parameters('subnets_default_name'))]",
                "action": "Allow",
                "state": "Succeeded"
            }
        ],
        "ipRules": [],
        "defaultAction": "Deny"
    },

ARM Template snippet - Subnet

"type": "Microsoft.Network/virtualNetworks/subnets",
"name": "[concat(parameters('virtualNetworks_DevWork_vnet_name'), '/', parameters('subnets_default_name'))]",
"apiVersion": "2018-01-01",
"scale": null,
"properties": {
    "provisioningState": "Succeeded",
    "addressPrefix": "10.0.0.0/24",
    "serviceEndpoints": [
        {
            "provisioningState": "Succeeded",
            "service": "Microsoft.Storage",
            "locations": [
                "eastus2",
                "centralus"
            ]
        }
    ]
}

[tombuildsstuff]

hey @HighwayofLife

Thanks for opening this issue

Support for this functionality has been previously requested in #1110 - rather than having multiple issues tracking the same thing I'm going to close this issue in favour of that one.

Thanks!

[hafizullah]

Hi @tombuildsstuff the link you have provided to the previously requested functionality references this issue. Could you please update the link so we can track that issue?

[tombuildsstuff]

@hafizullah @HighwayofLife apologies for the incorrect issue number - this is duplicate of #416

[HighwayofLife]

Ok, thanks... although that ticket doesn't contain any useful information. I'll copy it over there.

[xelor81]

Can someone print a small sippet how to use this this feature in tf file please?
I am completely green in reading go lang code but I have a big need to implement this in my tf plans.

[tombuildsstuff]

@xelor81 there's an example in the documentation here: https://www.terraform.io/docs/providers/azurerm/r/storage_account.html#example-usage-with-network-rules