New Data Source: azurerm_eventhub_sas

[neil-yechenwei]

fixes #7160

[neil-yechenwei]

@katbyte , thanks for the comment. I replied it. Please take another look. Thanks.

[manicminer]

Per my inline comment above, I think the escape sequence issue should be fixed in the data source (or helper func, or SDK).

[neil-yechenwei]

@manicminer , thanks for the comment. I replied it. Please take another look. Thanks.

[manicminer]

Thanks @neil-yechenwei, is there a reason this is an untyped data source? New data sources should use the typed SDK unless there is a compelling reason not to.

[neil-yechenwei]

@manicminer , I made this PR on my local about 2 years ago and this PR depends on another PR which is also submitted about 2 years ago. Given another PR is merged recently, so I submitted this PR. So shall we merge this PR first? Once I have bandwidth, I will submit another PR to convert it to typed resource. Does it make sense?

[manicminer]

@neil-yechenwei Unfortunately I don't believe we can merge this as a new untyped resource. Can you please refactor this as a typed resource? Apologies I didn't notice this earlier in the review cycle.

[neil-yechenwei]

@manicminer , I've converted it to typed resource. Please take another look. Thanks.

[manicminer]

Thanks for updating @neil-yechenwei, this LGTM 👍

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.