Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_linux_virtual_machine_scale_set - fix crash in nil value for auto_upgrade_minor_version_enabled #27353

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

jackofallops
Copy link
Member

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

PR Checklist

  • [x ] I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_linux_virtual_machine_scale_set - fix crash in nil value for auto_upgrade_minor_version_enabled

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #27307

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

extensionProps := virtualmachinescalesets.VirtualMachineScaleSetExtensionProperties{
Publisher: pointer.To(extensionRaw["publisher"].(string)),
Type: &extensionType,
TypeHandlerVersion: pointer.To(extensionRaw["type_handler_version"].(string)),
AutoUpgradeMinorVersion: pointer.To(extensionRaw["auto_upgrade_minor_version_enabled"].(bool)),
AutoUpgradeMinorVersion: pointer.To(autoUpgradeMinorVersion),
ProvisionAfterExtensions: utils.ExpandStringSlice(extensionRaw["extensions_to_provision_after_vm_creation"].([]interface{})),
Copy link
Contributor

@ms-zhenhua ms-zhenhua Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extensionRaw["extensions_to_provision_after_vm_creation"] also needs to be checked as it's not defined in azurerm_linux_virtual_machine_scale_set either.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out @ms-zhenhua, we're going to merge this for now and follow up on this in a separate PR

@stephybun stephybun added crash service/vmss Virtual Machine Scale Sets labels Oct 4, 2024
@stephybun stephybun merged commit 4d5af74 into main Oct 4, 2024
31 checks passed
@stephybun stephybun deleted the b/crash-orchi-vmss-assertion branch October 4, 2024 06:20
@github-actions github-actions bot added this to the v4.4.0 milestone Oct 4, 2024
stephybun added a commit that referenced this pull request Oct 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants