-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_linux_virtual_machine_scale_set
- fix crash in nil
value for auto_upgrade_minor_version_enabled
#27353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
extensionProps := virtualmachinescalesets.VirtualMachineScaleSetExtensionProperties{ | ||
Publisher: pointer.To(extensionRaw["publisher"].(string)), | ||
Type: &extensionType, | ||
TypeHandlerVersion: pointer.To(extensionRaw["type_handler_version"].(string)), | ||
AutoUpgradeMinorVersion: pointer.To(extensionRaw["auto_upgrade_minor_version_enabled"].(bool)), | ||
AutoUpgradeMinorVersion: pointer.To(autoUpgradeMinorVersion), | ||
ProvisionAfterExtensions: utils.ExpandStringSlice(extensionRaw["extensions_to_provision_after_vm_creation"].([]interface{})), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extensionRaw["extensions_to_provision_after_vm_creation"]
also needs to be checked as it's not defined in azurerm_linux_virtual_machine_scale_set
either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out @ms-zhenhua, we're going to merge this for now and follow up on this in a separate PR
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_linux_virtual_machine_scale_set
- fix crash innil
value forauto_upgrade_minor_version_enabled
This is a (please select all that apply):
Related Issue(s)
Fixes #27307
Note
If this PR changes meaningfully during the course of review please update the title and description as required.