Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_virtual_network_gateway_connection - make shared_key optional and computed again #27560

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

stephybun
Copy link
Member

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Reverts part of #26251

Related Issue(s)

Fixes #27400
Fixes #27217

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephybun - LGTM 🦊

@stephybun stephybun merged commit 2ab6e9d into main Oct 4, 2024
29 checks passed
@stephybun stephybun deleted the revert/pr-26251 branch October 4, 2024 06:34
@github-actions github-actions bot added this to the v4.4.0 milestone Oct 4, 2024
stephybun added a commit that referenced this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants