Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new resource azurerm_stack_hci_marketplace_gallery_image #27532

Merged
merged 8 commits into from
Oct 29, 2024
Merged

new resource azurerm_stack_hci_marketplace_gallery_image #27532

merged 8 commits into from
Oct 29, 2024

Conversation

teowa
Copy link
Contributor

@teowa teowa commented Sep 29, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

new resource azurerm_stack_hci_marketplace_gallery_image
azure doc: https://learn.microsoft.com/en-us/azure-stack/hci/manage/virtual-machine-image-azure-marketplace?tabs=azurecli
swagger: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/azurestackhci/resource-manager/Microsoft.AzureStackHCI/stable/2024-01-01/marketplaceGalleryImages.json

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@teowa teowa marked this pull request as draft September 29, 2024 09:17
ms-zhenhua
ms-zhenhua suggested changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@ms-zhenhua ms-zhenhua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @teowa ,
Thanks for this PR - I've taken a look through and left some comments inline. If we can fix those up, this should be good to go 👍

internal/services/azurestackhci/stack_hci_marketplace_gallery_image_resource.go Outdated
Comment on lines 76 to 81
"custom_location_id": {
Type: pluginsdk.TypeString,
Required: true,
ForceNew: true,
ValidateFunc: customlocations.ValidateCustomLocationID,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"custom_location_id": {
Type: pluginsdk.TypeString,
Required: true,
ForceNew: true,
ValidateFunc: customlocations.ValidateCustomLocationID,
},
"custom_location_id": commonschema.ResourceIDReferenceRequiredForceNew(&customlocations.CustomLocationId{}),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

internal/services/azurestackhci/stack_hci_marketplace_gallery_image_resource.go Outdated
Type: pluginsdk.TypeString,
Required: true,
ForceNew: true,
ValidateFunc: validation.StringInSlice([]string{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use PossibleValuesFor method if not exist None enum value

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

internal/services/azurestackhci/stack_hci_marketplace_gallery_image_resource.go Outdated
Type: pluginsdk.TypeString,
Required: true,
ForceNew: true,
ValidateFunc: validation.StringInSlice([]string{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use PossibleValuesFor method if not exist None enum value

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

internal/services/azurestackhci/stack_hci_marketplace_gallery_image_resource.go Show resolved Hide resolved
internal/services/azurestackhci/stack_hci_marketplace_gallery_image_resource.go Outdated
payload.Properties.ContainerId = pointer.To(config.StoragePathId)
}

if config.HypervGeneration != "" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since HypervGeneration is required, it won't be empty?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

website/docs/r/stack_hci_marketplace_gallery_image.html.markdown Outdated
layout: "azurerm"
page_title: "Azure Resource Manager: azurerm_stack_hci_marketplace_gallery_image"
description: |-
Manages a Azure Stack HCI Marketplace Gallery Image.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Manages a Azure Stack HCI Marketplace Gallery Image.
Manages an Azure Stack HCI Marketplace Gallery Image.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

website/docs/r/stack_hci_marketplace_gallery_image.html.markdown Outdated

# azurerm_stack_hci_marketplace_gallery_image

Manages a Azure Stack HCI Marketplace Gallery Image.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Manages a Azure Stack HCI Marketplace Gallery Image.
Manages an Azure Stack HCI Marketplace Gallery Image.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

website/docs/r/stack_hci_marketplace_gallery_image.html.markdown Outdated

* `location` - (Required) The Azure Region where the Azure Stack HCI Marketplace Gallery Image should exist. Changing this forces a new Azure Stack HCI Marketplace Gallery Image to be created.

* `custom_location_id` - (Required) The ID of Custom Location where the Azure Stack HCI Marketplace Gallery Image should exist. Changing this forces a new resource to be created.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `custom_location_id` - (Required) The ID of Custom Location where the Azure Stack HCI Marketplace Gallery Image should exist. Changing this forces a new resource to be created.
* `custom_location_id` - (Required) The ID of the Custom Location where the Azure Stack HCI Marketplace Gallery Image should exist. Changing this forces a new resource to be created.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

website/docs/r/stack_hci_marketplace_gallery_image.html.markdown Outdated

* `hyperv_generation` - (Required) The hypervisor generation of the Azure Stack HCI Marketplace Gallery Image. Possible values are `V1` and `V2`. Changing this forces a new Azure Stack HCI Marketplace Gallery Image to be created.

* `identifier` - (Required) One or more `identifier` blocks as defined below. Changing this forces a new Azure Stack HCI Marketplace Gallery Image to be created.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `identifier` - (Required) One or more `identifier` blocks as defined below. Changing this forces a new Azure Stack HCI Marketplace Gallery Image to be created.
* `identifier` - (Required) An `identifier` block as defined below. Changing this forces a new Azure Stack HCI Marketplace Gallery Image to be created.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

website/docs/r/stack_hci_marketplace_gallery_image.html.markdown Outdated

---

A `identifier` block supports the following:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A `identifier` block supports the following:
An `identifier` block supports the following:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@teowa
Copy link
Contributor Author

teowa commented Oct 11, 2024

Hi @ms-zhenhua , thanks for reviewing this! I have modified the code, please kindly take another look.

image
test log

ms-zhenhua
ms-zhenhua approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@ms-zhenhua ms-zhenhua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @teowa ,

Thank you for the updates. LGTM~

@teowa teowa marked this pull request as ready for review October 14, 2024 02:18
katbyte
katbyte approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❄️

@katbyte katbyte merged commit 7bb6a14 into hashicorp:main Oct 29, 2024
46 checks passed
katbyte added a commit that referenced this pull request Oct 29, 2024
@katbyte
Update CHANGELOG.md #27532
0ae6436
@github-actions github-actions bot added this to the v4.8.0 milestone Oct 29, 2024
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ms-zhenhua ms-zhenhua ms-zhenhua approved these changes

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation new-resource service/azure-stack-hci size/XL
Projects
None yet
Milestone
v4.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@teowa @katbyte @ms-zhenhua @rcskosir