new resource azurerm_stack_hci_marketplace_gallery_image
#27532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m into stackhci_marketplace_gallery_image
github-actions
bot
added
documentation
service/azure-stack-hci
size/XL
waiting-response
labels
ms-zhenhua
suggested changes
Oct 10, 2024
There was a problem hiding this comment.
Hi @teowa ,
Thanks for this PR - I've taken a look through and left some comments inline. If we can fix those up, this should be good to go 👍
Comment on lines
76
to
81
| "custom_location_id": { | ||
| Type: pluginsdk.TypeString, | ||
| Required: true, | ||
| ForceNew: true, | ||
| ValidateFunc: customlocations.ValidateCustomLocationID, | ||
| }, |
There was a problem hiding this comment.
Suggested change
| "custom_location_id": { | |
| Type: pluginsdk.TypeString, | |
| Required: true, | |
| ForceNew: true, | |
| ValidateFunc: customlocations.ValidateCustomLocationID, | |
| }, | |
| "custom_location_id": commonschema.ResourceIDReferenceRequiredForceNew(&customlocations.CustomLocationId{}), |
| Type: pluginsdk.TypeString, | ||
| Required: true, | ||
| ForceNew: true, | ||
| ValidateFunc: validation.StringInSlice([]string{ |
There was a problem hiding this comment.
please use PossibleValuesFor method if not exist None enum value
| Type: pluginsdk.TypeString, | ||
| Required: true, | ||
| ForceNew: true, | ||
| ValidateFunc: validation.StringInSlice([]string{ |
There was a problem hiding this comment.
please use PossibleValuesFor method if not exist None enum value
internal/services/azurestackhci/stack_hci_marketplace_gallery_image_resource.go
Show resolved
Hide resolved
| payload.Properties.ContainerId = pointer.To(config.StoragePathId) | ||
| } | ||
|
|
||
| if config.HypervGeneration != "" { |
There was a problem hiding this comment.
since HypervGeneration is required, it won't be empty?
| layout: "azurerm" | ||
| page_title: "Azure Resource Manager: azurerm_stack_hci_marketplace_gallery_image" | ||
| description: |- | ||
| Manages a Azure Stack HCI Marketplace Gallery Image. |
There was a problem hiding this comment.
Suggested change
| Manages a Azure Stack HCI Marketplace Gallery Image. | |
| Manages an Azure Stack HCI Marketplace Gallery Image. |
|
|
||
| # azurerm_stack_hci_marketplace_gallery_image | ||
|
|
||
| Manages a Azure Stack HCI Marketplace Gallery Image. |
There was a problem hiding this comment.
Suggested change
| Manages a Azure Stack HCI Marketplace Gallery Image. | |
| Manages an Azure Stack HCI Marketplace Gallery Image. |
|
|
||
| * `location` - (Required) The Azure Region where the Azure Stack HCI Marketplace Gallery Image should exist. Changing this forces a new Azure Stack HCI Marketplace Gallery Image to be created. | ||
|
|
||
| * `custom_location_id` - (Required) The ID of Custom Location where the Azure Stack HCI Marketplace Gallery Image should exist. Changing this forces a new resource to be created. |
There was a problem hiding this comment.
Suggested change
| * `custom_location_id` - (Required) The ID of Custom Location where the Azure Stack HCI Marketplace Gallery Image should exist. Changing this forces a new resource to be created. | |
| * `custom_location_id` - (Required) The ID of the Custom Location where the Azure Stack HCI Marketplace Gallery Image should exist. Changing this forces a new resource to be created. |
|
|
||
| * `hyperv_generation` - (Required) The hypervisor generation of the Azure Stack HCI Marketplace Gallery Image. Possible values are `V1` and `V2`. Changing this forces a new Azure Stack HCI Marketplace Gallery Image to be created. | ||
|
|
||
| * `identifier` - (Required) One or more `identifier` blocks as defined below. Changing this forces a new Azure Stack HCI Marketplace Gallery Image to be created. |
There was a problem hiding this comment.
Suggested change
| * `identifier` - (Required) One or more `identifier` blocks as defined below. Changing this forces a new Azure Stack HCI Marketplace Gallery Image to be created. | |
| * `identifier` - (Required) An `identifier` block as defined below. Changing this forces a new Azure Stack HCI Marketplace Gallery Image to be created. |
|
|
||
| --- | ||
|
|
||
| A `identifier` block supports the following: |
There was a problem hiding this comment.
Suggested change
| A `identifier` block supports the following: | |
| An `identifier` block supports the following: |
…m into stackhci_marketplace_gallery_image
|
Hi @ms-zhenhua , thanks for reviewing this! I have modified the code, please kindly take another look. |
ms-zhenhua
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
new resource
azurerm_stack_hci_marketplace_gallery_imageazure doc: https://learn.microsoft.com/en-us/azure-stack/hci/manage/virtual-machine-image-azure-marketplace?tabs=azurecli
swagger: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/azurestackhci/resource-manager/Microsoft.AzureStackHCI/stable/2024-01-01/marketplaceGalleryImages.json
PR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_resource- support for thething1property [GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #0000
Note
If this PR changes meaningfully during the course of review please update the title and description as required.