Allow Icmp protocol for azure network security rule

[ghost]

This issue was originally opened by @alexanderfichel as hashicorp/terraform#22215. It was migrated here as a result of the provider split. The original body of the issue is below.

---

Please add Icmp option for protocol.

Current terraform template (section):

resource "azurerm_network_security_rule" "icmp" {
  name                        = "ICMP"
  priority                    = 3000
  direction                   = "Inbound"
  access                      = "Allow"
  protocol                    = "Icmp"
  source_port_range           = "*"
  destination_port_range      = "*"
  source_address_prefix       = "*"
  destination_address_prefix  = "*"
  resource_group_name         = "${azurerm_resource_group.cluster_uae.name}"
  network_security_group_name = "${azurerm_network_security_group.cluster_uae.name}"
}

Error:

Error: expected protocol to be one of [* Tcp Udp], got Icmp

  on clusters/azure/uae/security_groups.tf line 71, in resource "azurerm_network_security_rule" "icmp":
  71: resource "azurerm_network_security_rule" "icmp" {

Terraform v0.12.5

Web console allows that to change manually:

[ghost]

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!