new resource: azurerm_sentinel_data_connector_office_365

[magodo]

new resource: azurerm_sentinel_data_connector_office_365

[tombuildsstuff]

hey @magodo

Thanks for this PR - I've taken a look through and left some (mostly minor) comments inline - if we can fix those up then this should be otherwise good to go 👍

Thanks!

[magodo]

@tombuildsstuff

Thank you for the comments! I've rebased the original commit onto your last merged base commit, and also have resolved the review comments but the etag one. Please take another review.

[katbyte]

Hey @magodo - looks l ike the tests are failing for all the new data connector PRs:

------- Stdout: -------
=== RUN   TestAccAzureRMSentinelDataConnectorOffice365_complete
=== PAUSE TestAccAzureRMSentinelDataConnectorOffice365_complete
=== CONT  TestAccAzureRMSentinelDataConnectorOffice365_complete
    testing.go:620: Step 1/2 error: Error running apply: 
        Error: A resource with the ID "/subscriptions/*******/resourceGroups/acctestRG-sentinel-210225200909729587/providers/Microsoft.OperationalInsights/workspaces/acctestLAW-210225200909729587/providers/Microsoft.SecurityInsights/dataConnectors/accTestDC-210225200909729587" already exists - to be managed via Terraform this resource needs to be imported into the State. Please see the resource documentation for "azurerm_sentinel_data_connector_office_365" for more information.
        
          on config792808867/terraform_plugin_test.tf line 22, in resource "azurerm_sentinel_data_connector_office_365" "test":
          22: resource "azurerm_sentinel_data_connector_office_365" "test" {
        
        
--- FAIL: TestAccAzureRMSentinelDataConnectorOffice365_complete (178.39s)
FAIL

------- Stderr: -------
2021/02/25 20:09:09 [DEBUG] not using binary driver name, it's no longer needed
2021/02/25 20:09:09 [DEBUG] not using binary driver name, it's no longer needed

[magodo]

@katbyte I've fixed the error now.

💤 make testacc TEST=./azurerm/internal/services/sentinel TESTARGS='-run TestAccAzureRMSentinelDataConnectorOffice365_'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/sentinel -v -run TestAccAzureRMSentinelDataConnectorOffice365_ -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMSentinelDataConnectorOffice365_basic
=== PAUSE TestAccAzureRMSentinelDataConnectorOffice365_basic
=== RUN   TestAccAzureRMSentinelDataConnectorOffice365_complete
=== PAUSE TestAccAzureRMSentinelDataConnectorOffice365_complete
=== RUN   TestAccAzureRMSentinelDataConnectorOffice365_update
=== PAUSE TestAccAzureRMSentinelDataConnectorOffice365_update
=== RUN   TestAccAzureRMSentinelDataConnectorOffice365_requiresImport
=== PAUSE TestAccAzureRMSentinelDataConnectorOffice365_requiresImport
=== CONT  TestAccAzureRMSentinelDataConnectorOffice365_basic
=== CONT  TestAccAzureRMSentinelDataConnectorOffice365_requiresImport
=== CONT  TestAccAzureRMSentinelDataConnectorOffice365_update
=== CONT  TestAccAzureRMSentinelDataConnectorOffice365_complete
--- PASS: TestAccAzureRMSentinelDataConnectorOffice365_basic (180.22s)
--- PASS: TestAccAzureRMSentinelDataConnectorOffice365_requiresImport (186.31s)
--- PASS: TestAccAzureRMSentinelDataConnectorOffice365_complete (186.90s)
--- PASS: TestAccAzureRMSentinelDataConnectorOffice365_update (585.19s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/sentinel    585.241s

[magodo]

The etag related code can be removed once: Azure/azure-rest-api-specs#13203 is resolved.

[tombuildsstuff]

hey @magodo

Thanks for pushing those changes - taking a look through aside from a couple of minor comments this otherwise LGTM 👍

Thanks!

[magodo]

@tombuildsstuff I've updated accordingly, thank you!

[tombuildsstuff]

LGTM 👍

[tombuildsstuff]

Tests pass:

[ghost]

This has been released in version 2.50.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.50.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!