Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_local_network_gateway - mark address_space argument optional #10983

Merged

Conversation

ms-henglu
Copy link
Contributor

To address issue #10891

Below paste the run pass result for the test cases

=== RUN   TestAccLocalNetworkGateway_updateAddressSpace
=== PAUSE TestAccLocalNetworkGateway_updateAddressSpace
=== CONT  TestAccLocalNetworkGateway_updateAddressSpace
--- PASS: TestAccLocalNetworkGateway_updateAddressSpace (371.85s)
PASS

According to https://docs.microsoft.com/en-us/azure/templates/microsoft.network/localnetworkgateways?tabs=json, address_space argument is not required.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu - LGTM 👍

@katbyte katbyte added this to the v2.52.0 milestone Mar 17, 2021
@katbyte katbyte changed the title mark address_space argument optional azurerm_local_network_gateway - mark address_space argument optional Mar 17, 2021
@katbyte katbyte merged commit 8ffdb51 into hashicorp:master Mar 17, 2021
katbyte added a commit that referenced this pull request Mar 17, 2021
@ghost
Copy link

ghost commented Mar 18, 2021

This has been released in version 2.52.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.52.0"
}
# ... other configuration ...

tombuildsstuff pushed a commit that referenced this pull request Apr 6, 2021
@ghost
Copy link

ghost commented Apr 17, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants