Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location validate fix in CosmosDbAccount tests #1347

Merged
merged 1 commit into from
Jun 6, 2018
Merged

Location validate fix in CosmosDbAccount tests #1347

merged 1 commit into from
Jun 6, 2018

Conversation

lrxtom2
Copy link
Contributor

@lrxtom2 lrxtom2 commented Jun 5, 2018

The expected value is being pulled from the environment variable which is uppercased, which for value in the state file/API are returned lowercase. To keep location pulled from environment variable same as state file.
Related 11 test cases:
TestAccAzureRMCosmosDBAccount_boundedStaleness
TestAccAzureRMCosmosDBAccount_boundedStaleness_complete
TestAccAzureRMCosmosDBAccount_complete
TestAccAzureRMCosmosDBAccount_consistency_change
TestAccAzureRMCosmosDBAccount_consistentPrefix
TestAccAzureRMCosmosDBAccount_eventualConsistency
TestAccAzureRMCosmosDBAccount_geoReplicated_add_remove
TestAccAzureRMCosmosDBAccount_geoReplicated_rename
TestAccAzureRMCosmosDBAccount_mongoDB
TestAccAzureRMCosmosDBAccount_session
TestAccAzureRMCosmosDBAccount_strong

@katbyte katbyte added this to the 1.7.0 milestone Jun 6, 2018
@katbyte katbyte self-requested a review June 6, 2018 01:33
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lrxtom2,

Thank you for finding and fixing this! LGTM 💯

@katbyte katbyte merged commit 0e0d185 into hashicorp:master Jun 6, 2018
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants