Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_automation_module - support update existing global automation module version #18434

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented Sep 19, 2022

If you try update an existing global module, the current logic will block and raise an ImportAsExistsError which is inconvenient and confusing for customers to do an import-then-apply to update module version. So this pr tries to update an existing global module. one side effect is the isGlobal property will be set to false(the same as import-then-apply`

Fixes: #18198

@wuxu92 wuxu92 changed the title azurerm_automation_module - fix update existing global automation module instead of import as error azurerm_automation_module - support update existing global automation module Sep 19, 2022
@wuxu92 wuxu92 changed the title azurerm_automation_module - support update existing global automation module azurerm_automation_module - support update existing global automation module version Sep 19, 2022
@wuxu92 wuxu92 marked this pull request as draft September 19, 2022 08:31
@wuxu92 wuxu92 marked this pull request as ready for review September 19, 2022 08:50
@katbyte katbyte self-assigned this Sep 21, 2022
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚙️

@katbyte katbyte merged commit c14cba9 into hashicorp:main Sep 27, 2022
@github-actions github-actions bot added this to the v3.25.0 milestone Sep 27, 2022
@github-actions
Copy link

This functionality has been released in v3.25.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@wuxu92 wuxu92 deleted the fix/globalmodule branch October 17, 2022 03:38
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_automation_module can't import newer versions of default modules
2 participants