Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

containerregistry - swap to hashicorp/go-azure-sdk #21315

Merged
merged 5 commits into from
Apr 11, 2023
Merged

containerregistry - swap to hashicorp/go-azure-sdk #21315

merged 5 commits into from
Apr 11, 2023

Conversation

stephybun
Copy link
Member

Failing tests currently fail on main, will look into them separately
image
image

Ignored tests were run locally which pass:

--- PASS: TestAccContainerRegistryTask_systemTask (267.99s)
--- PASS: TestAccContainerRegistryTask_requiresImport (269.90s)
--- PASS: TestAccContainerRegistryTask_dockerStep (535.36s)
--- PASS: TestAccContainerRegistryTask_dockerStepTimerTrigger (538.68s)
--- PASS: TestAccContainerRegistryTask_fileTaskStep (540.15s)
--- PASS: TestAccContainerRegistryTask_dockerStepBaseImageTrigger (543.42s)
--- PASS: TestAccContainerRegistryTask_encodedTaskStep (601.53s)
--- PASS: TestAccContainerRegistryTask_dockerStepSourceTrigger (662.53s)
--- PASS: TestAccContainerRegistryTask_identity (673.36s)
--- PASS: TestAccContainerRegistryTask_fileTaskStepRegistryCredential (836.64s)
--- PASS: TestAccContainerRegistryTaskSchedule_basic (409.95s)

@stephybun stephybun requested a review from a team April 6, 2023 10:59
katbyte
katbyte approved these changes Apr 7, 2023
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥣

@stephybun stephybun merged commit 68ba991 into main Apr 11, 2023
@stephybun stephybun deleted the f/swap-sdk-containerregistry branch April 11, 2023 07:31
@github-actions github-actions bot added this to the v3.51.0 milestone Apr 11, 2023
@jackofallops jackofallops modified the milestones: v3.51.0, v3.52.0 Apr 11, 2023
stephybun added a commit that referenced this pull request Apr 12, 2023
@stephybun
Update for #21314, #21337, #21379, #21370, #21315
10a2e2a
@github-actions
Copy link

This functionality has been released in v3.52.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@magodo magodo mentioned this pull request Apr 19, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
dependencies service/container-registry service/machine-learning size/XL
Projects
None yet
Milestone
v3.52.0
Development

Successfully merging this pull request may close these issues.
3 participants
@stephybun @katbyte @jackofallops