azurerm_function_app: Support full site_config as with app_service. #2138
Conversation
torresdal
commented
Oct 23, 2018
torresdal
commented
- Reference same schema as in AppService
- Use Same expand/flatten as in AppService
- Added integration test for ip_restrictions
* Reference same schema as in AppService * Use Same expand/flatten as in AppService * Added integration test for ip_restrictions
torresdal
changed the title
There was a problem hiding this comment.
Hi @torresdal,
Thank you for this contribution! It LGTM aside from could we get some more tests to validate the other properties can be set & then updated?
TestAccAzureRMFunctionApp_siteConig -> TestAccAzureRMFunctionApp_siteConfigUpdate
|
hey @torresdal Since we've not heard back from you here (and there's outstanding comments/a rebase required) - I'm going to close this PR for the moment. If you (or someone else in the future) can fix those up, we'll be happy to take another look and add support for this functionality - whilst I'm closing this PR I'd like to thank you for this contribution :) Thanks! |
|
This has been released in version 1.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.23.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
