azurerm_container_app: Add support for ip_security_restriction block #23870

davidkarlsen · 2023-11-11T16:31:26Z

Adds support for ingress ip security rules / ingress restrictions by exposing a new child element on the ingress type on the azurerm_container_app resource.

Fixes #21774 #21448

davidkarlsen · 2023-11-13T21:58:39Z

All tests that don't require a special runner passes in the workflows here: davidkarlsen#1

davidkarlsen · 2023-11-14T09:48:16Z

@tombuildsstuff can I get a review?

davidkarlsen · 2023-11-16T14:24:21Z

@jackofallops perhaps? Since I saw you did some review on workload-profiles too?

jackofallops

Hi @davidkarlsen - Thanks for this PR.
Just a couple things to take a look at noted below and think this will be good to run through testing 👍

Thanks again!

internal/services/containerapps/container_app_resource_test.go

internal/services/containerapps/helpers/container_apps.go

Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>

Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>

Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>

jackofallops

Hi @davidkarlsen - thanks for the changes, just a few more items to take a look at, and then I think we'll be good to test and hopefully get merged.

Thanks!

internal/services/containerapps/helpers/container_apps.go

internal/services/containerapps/container_app_resource_test.go

website/docs/r/container_app.html.markdown

Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>

davidkarlsen · 2023-11-28T18:28:29Z

@jackofallops fixed and formatted!

davidkarlsen · 2023-11-30T00:45:33Z

@jackofallops can this be merged then - since it passes?

davidkarlsen · 2023-12-13T20:09:56Z

Any interest in this?

davidkarlsen · 2023-12-20T16:31:48Z

?

tdkeeley · 2023-12-20T16:35:48Z

Whoever approves this will have my undying gratitude.

ilmax · 2023-12-21T09:03:25Z

@jackofallops ping pretty please 😅

ilmax · 2024-01-02T09:50:46Z

/cc @katbyte

katbyte

LGTM 🦕

<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>"hashicorp/azurerm" updated from "3.86.0" to "3.87.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.87.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.87.0
ENHANCEMENTS:

* dependencies: updating to `v0.20240112.1095456` of `github.com/hashicorp/go-azure-sdk` [GH-24477]
* dependencies: updating to `v0.65.1` of `github.com/hashicorp/go-azure-helpers` [GH-24479]
* `kusto`: updating to use the base layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest` [GH-24477]
* `azurerm_container_group` - support for the `priority` property [GH-24374]
* Data Source: `azurerm_application_gateway` - support for the `trusted_client_certificate.data` property [GH-24474]

## 3.87.0 (January 11, 2024)

FEATURES:

* New Data Source: `azurerm_network_manager` ([#24398](hashicorp/terraform-provider-azurerm#24398 New Resource: `azurerm_security_center_server_vulnerability_assessments_setting` ([#24299](https://github.com/hashicorp/terraform-provider-azurerm/issues/24299))

ENHANCEMENTS:

* dependencies: updating to `v0.20240111.1094251` of `github.com/hashicorp/go-azure-sdk` ([#24463](hashicorp/terraform-provider-azurerm#24463 Data Source: `azurerm_mssql_database` - support for `identity`, `transparent_data_encryption_enabled`, `transparent_data_encryption_key_vault_key_id` and `transparent_data_encryption_key_automatic_rotation_enabled` ([#24412](hashicorp/terraform-provider-azurerm#24412 Data Source: `azurerm_mssql_server` - support for `transparent_data_encryption_key_vault_key_id` ([#24412](hashicorp/terraform-provider-azurerm#24412 `machinelearning`: updating to API Version `2023-10-01` ([#24416](hashicorp/terraform-provider-azurerm#24416 `paloaltonetworks`: updating to API Version `2023-09-01` ([#24290](hashicorp/terraform-provider-azurerm#24290 `azurerm_container_app` - update create time validations for `ingress.0.traffic_weight` ([#24042](hashicorp/terraform-provider-azurerm#24042 `azurerm_container_app`- support for the `ip_security_restriction` block ([#23870](hashicorp/terraform-provider-azurerm#23870 `azurerm_kubernetes_cluster` - properties in `default_node_pool.linux_os_config.sysctl_config` are now updateable via node pool cycling ([#24397](hashicorp/terraform-provider-azurerm#24397 `azurerm_linux_web_app` - support the `VS2022` value for the `remote_debugging_version` property ([#24407](hashicorp/terraform-provider-azurerm#24407 `azurerm_mssql_database` - support for `identity`, `transparent_data_encryption_key_vault_key_id` and `transparent_data_encryption_key_automatic_rotation_enabled` ([#24412](hashicorp/terraform-provider-azurerm#24412 `azurerm_postgres_flexible_server` - the `sku_name` property now supports being set to `MO_Standard_E96ds_v5` ([#24367](hashicorp/terraform-provider-azurerm#24367 `azurerm_role_assignment` - support for the `principal_type` property ([#24271](hashicorp/terraform-provider-azurerm#24271 `azurerm_windows_web_app` - support the `VS2022` value for the `remote_debugging_version` property ([#24407](hashicorp/terraform-provider-azurerm#24407 `azurerm_cdn_frontdoor_firewall_policy` - support for `request_body_check_enabled` property ([#24406](https://github.com/hashicorp/terraform-provider-azurerm/issues/24406))

BUG FIXES:

* Data Source: `azurerm_role_definition` - fix `role_definition_id` ([#24418](hashicorp/terraform-provider-azurerm#24418 `azurerm_api_management` - the `sku_name` property can now be updated ([#24431](hashicorp/terraform-provider-azurerm#24431 `azurerm_arc_kubernetes_flux_configuration` - prevent a bug where certain sensitive properties for `bucket` and `git_repository` were being overwritten after an update to the resource is made ([#24066](hashicorp/terraform-provider-azurerm#24066 `azurerm_kubernetes_flux_configuration` - prevent a bug where certain sensitive properties for `bucket` and `git_repository` were being overwritten after an update to the resource is made ([#24066](hashicorp/terraform-provider-azurerm#24066 `azure_linux_web_app` - prevent a bug in App Service processing of `application_stack` in updates to `site_config` ([#24424](hashicorp/terraform-provider-azurerm#24424 `azure_linux_web_app_slot` - Fix bug in App Service processing of `application_stack` in updates to `site_config` ([#24424](hashicorp/terraform-provider-azurerm#24424 `azurerm_network_manager_deployment` - update creation wait logic to better tolerate the api returning not found ([#24330](hashicorp/terraform-provider-azurerm#24330 `azurerm_virtual_machine_data_disk_attachment` - do not update applications profile with disks ([#24145](hashicorp/terraform-provider-azurerm#24145 `azure_windows_web_app` - prevent a bug in App Service processing of `application_stack` in updates to `site_config` ([#24424](hashicorp/terraform-provider-azurerm#24424 `azure_windows_web_app_slot` - prevent a bug in App Service processing of `application_stack` in updates to `site_config` ([#24424](hashicorp/terraform-provider-azurerm#24424 `azurerm_maintenance_configuration` - set the `reboot` property in flatten from `AlwaysReboot` to `Always` ([#24376](hashicorp/terraform-provider-azurerm#24376 `azurerm_container_app_environment` - the `workload_profile` property can now be updated ([#24409](https://github.com/hashicorp/terraform-provider-azurerm/issues/24409))


</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/terraform-jobs/job/azure/job/main/1004/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>

github-actions · 2024-04-30T02:05:16Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added service/container-apps size/M labels Nov 12, 2023

davidkarlsen marked this pull request as ready for review November 12, 2023 12:01

github-actions bot added documentation size/L and removed size/M labels Nov 12, 2023

davidkarlsen changed the title ~~Feature/21774 secrules~~ azurerm_container_app: Add support for ingress ip security rules Nov 12, 2023

github-actions bot added waiting-response and removed waiting-response labels Nov 13, 2023

davidkarlsen added 8 commits November 13, 2023 14:46

add type and mappers

8c1bea0

add schema

042ec45

add test

01902ca

add docs

342deae

more concise validation

107d4c4

fix typos

539b984

drop unused arg

21a58e4

fix lints

800c788

davidkarlsen force-pushed the feature/21774-secrules branch from 3c1f1b3 to 800c788 Compare November 13, 2023 13:47

jackofallops requested changes Nov 23, 2023

View reviewed changes

internal/services/containerapps/container_app_resource_test.go Outdated Show resolved Hide resolved

internal/services/containerapps/helpers/container_apps.go Outdated Show resolved Hide resolved

internal/services/containerapps/helpers/container_apps.go Outdated Show resolved Hide resolved

github-actions bot added the waiting-response label Nov 23, 2023

fix review-comment

cc480ad

Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>

github-actions bot removed the waiting-response label Nov 23, 2023

Fix review-comment

0396465

Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>

katbyte added the waiting-response label Nov 24, 2023

fix lint

0d08ddb

Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>

github-actions bot removed the waiting-response label Nov 24, 2023

add test

2e3c81e

github-actions bot removed the waiting-response label Nov 27, 2023

jackofallops requested changes Nov 28, 2023

View reviewed changes

github-actions bot added the waiting-response label Nov 28, 2023

Update internal/services/containerapps/container_app_resource_test.go

b1987cf

Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>

github-actions bot removed the waiting-response label Nov 28, 2023

davidkarlsen and others added 4 commits November 28, 2023 19:24

Update internal/services/containerapps/container_app_resource_test.go

d76578c

Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>

Update website/docs/r/container_app.html.markdown

bf6e472

Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>

fix formatting

f35ac0c

Update internal/services/containerapps/helpers/container_apps.go

80b878e

Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>

davidkarlsen requested a review from jackofallops December 1, 2023 15:58

merge main

18e793b

katbyte changed the title ~~azurerm_container_app: Add support for ingress ip security rules~~ azurerm_container_app: Add support for ip_security_restriction block Jan 8, 2024

katbyte approved these changes Jan 9, 2024

View reviewed changes

katbyte merged commit 3c8a50b into hashicorp:main Jan 9, 2024
33 checks passed

github-actions bot added this to the v3.87.0 milestone Jan 9, 2024

katbyte added a commit that referenced this pull request Jan 9, 2024

Update CHANGELOG.md #23870

3822821

This was referenced Jan 9, 2024

Could you please include Ip Restrictions in Ingress for azurerm_container_apps service? #21448

Closed

Support for IP Security Restrictions Mode Azure/terraform-azure-container-apps#29

Open

davidkarlsen deleted the feature/21774-secrules branch January 14, 2024 13:12

kzryzstof mentioned this pull request Jan 15, 2024

3.87.0 - breaking change for data azurerm_container_app #24494

Closed

1 task

github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

azurerm_container_app: Add support for ip_security_restriction block #23870

azurerm_container_app: Add support for ip_security_restriction block #23870

davidkarlsen commented Nov 11, 2023 •

edited

Loading

davidkarlsen commented Nov 13, 2023

davidkarlsen commented Nov 14, 2023

davidkarlsen commented Nov 16, 2023

jackofallops left a comment

jackofallops left a comment

davidkarlsen commented Nov 28, 2023

davidkarlsen commented Nov 30, 2023

davidkarlsen commented Dec 13, 2023

davidkarlsen commented Dec 20, 2023

tdkeeley commented Dec 20, 2023

ilmax commented Dec 21, 2023

ilmax commented Jan 2, 2024

katbyte left a comment

github-actions bot commented Apr 30, 2024

azurerm_container_app: Add support for ip_security_restriction block #23870

azurerm_container_app: Add support for ip_security_restriction block #23870

Conversation

davidkarlsen commented Nov 11, 2023 • edited Loading

davidkarlsen commented Nov 13, 2023

davidkarlsen commented Nov 14, 2023

davidkarlsen commented Nov 16, 2023

jackofallops left a comment

Choose a reason for hiding this comment

jackofallops left a comment

Choose a reason for hiding this comment

davidkarlsen commented Nov 28, 2023

davidkarlsen commented Nov 30, 2023

davidkarlsen commented Dec 13, 2023

davidkarlsen commented Dec 20, 2023

tdkeeley commented Dec 20, 2023

ilmax commented Dec 21, 2023

ilmax commented Jan 2, 2024

katbyte left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 30, 2024

davidkarlsen commented Nov 11, 2023 •

edited

Loading