New Resource: azurerm_automation_powershell72_module

[aristosvo]

Done

• Test if I can get Powershell 7.2 modules working
  
• Docs
• Open PR dependencies: update hashicorp/go-azure-sdk to v0.20231122.1165504 #24013 to get a valid SDK version merged
• Create a separate PR for only the update to 2023-11-01 (sdk: update Automation to 2023-11-01 #24017)
• Rebase PR
• Rewritten to typed resource, tested
  

Fixes #24252

[stephybun]

Thanks for this new resource @aristosvo.

Unfortunately since this would need to be re-written into a typed resource in the coming months due to the changes we need to make within the provider to support framework.

Since you have experience writing typed resources would you mind converting this to a typed resource now? It would help us out a lot!

[aristosvo]

Hi @stephybun! Thanks for the feedback.

I wouldn't mind, can you clarify if that would include rewriting to use a tfschema structure like used for webapps? Or just as shown in the contributing guide?

[stephybun]

@aristosvo typed resources should always have a tfschema defined. We need to update the docs to reflect that, thanks for pointing that out!

[aristosvo]

@stephybun A lot of the resources in the provider just return nil to the ModelObject(). Should these resources then be enhanced as well, is that some sort of an intermediate step?

[stephybun]

@aristosvo yes, ultimately resources that are doing this will need to be updated to define and return a tfschema model.

[stephybun]

Thanks for rewriting this @aristosvo! I've made a first pass through and it's looking mostly fine. If you can take a look at the couple of comments left in-line, then we can take another look through.

[stephybun]

I'm not that familiar with the automation service, but this seems like it could be problematic if the global module was created by and is being managed by terraform? Could you elaborate some more on this?

[aristosvo]

Actually I didn't know exactly what the functionality is we are supporting here, but it was an feature request on azurerm_automation_module which seems to make sense to also have in azurerm_automation_powershell72_module: #18198

[katbyte]

Seem to have some test failures:

------- Stdout: -------
=== RUN   TestAccAutomationPowerShell72Module_complete
=== PAUSE TestAccAutomationPowerShell72Module_complete
=== CONT  TestAccAutomationPowerShell72Module_complete
    testcase.go:113: Step 1/2 error: Error running pre-apply refresh: exit status 1
        
        Error: Missing required argument
        
          on terraform_plugin_test.tf line 33, in resource "azurerm_automation_powershell72_module" "test":
          33: resource "azurerm_automation_powershell72_module" "test" {
        
        The argument "automation_account_id" is required, but no definition was
        found.
        
        Error: Unsupported argument
        
          on terraform_plugin_test.tf line 35, in resource "azurerm_automation_powershell72_module" "test":
          35:   resource_group_name     = azurerm_resource_group.test.name
        
        An argument named "resource_group_name" is not expected here.
        
        Error: Unsupported argument
        
          on terraform_plugin_test.tf line 36, in resource "azurerm_automation_powershell72_module" "test":
          36:   automation_account_name = azurerm_automation_account.test.name
        
        An argument named "automation_account_name" is not expected here.
--- FAIL: TestAccAutomationPowerShell72Module_complete (15.50s)
FAIL

[aristosvo]

Seem to have some test failures:

------- Stdout: -------
=== RUN   TestAccAutomationPowerShell72Module_complete
=== PAUSE TestAccAutomationPowerShell72Module_complete
=== CONT  TestAccAutomationPowerShell72Module_complete
    testcase.go:113: Step 1/2 error: Error running pre-apply refresh: exit status 1
        
        Error: Missing required argument
        
          on terraform_plugin_test.tf line 33, in resource "azurerm_automation_powershell72_module" "test":
          33: resource "azurerm_automation_powershell72_module" "test" {
        
        The argument "automation_account_id" is required, but no definition was
        found.
        
        Error: Unsupported argument
        
          on terraform_plugin_test.tf line 35, in resource "azurerm_automation_powershell72_module" "test":
          35:   resource_group_name     = azurerm_resource_group.test.name
        
        An argument named "resource_group_name" is not expected here.
        
        Error: Unsupported argument
        
          on terraform_plugin_test.tf line 36, in resource "azurerm_automation_powershell72_module" "test":
          36:   automation_account_name = azurerm_automation_account.test.name
        
        An argument named "automation_account_name" is not expected here.
--- FAIL: TestAccAutomationPowerShell72Module_complete (15.50s)
FAIL

@katbyte Tests are fixed!

[katbyte]

LGTM 🚜

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.