Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies: updating to v0.20240110.1102249 of github.com/hashicorp/go-azure-sdk #24453

Merged
merged 3 commits into from
Jan 10, 2024
Merged

dependencies: updating to v0.20240110.1102249 of github.com/hashicorp/go-azure-sdk #24453

merged 3 commits into from
Jan 10, 2024

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Jan 10, 2024 •
edited
Loading

This PR updates to v0.20240110.1102249 of github.com/hashicorp/go-azure-sdk - which also updates the Resource IDs promoted to be Common IDs in hashicorp/pandora#3031

@tombuildsstuff tombuildsstuff requested a review from a team January 10, 2024 11:20
@tombuildsstuff tombuildsstuff changed the title dependencies: updating to v0.20240110.1102249 of github.com/hashicorp/go-azure-sdk dependencies: updating to v0.20240110.1102249 of github.com/hashicorp/go-azure-sdk Jan 10, 2024
catriona-m
catriona-m approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff
disks: fixing the compilation error
74efad5 
I ran the tests against `./internal/services/disks` and not `./...`
@tombuildsstuff
Copy link
Contributor Author

Check for new usages of deprecated functionality / test (pull_request) Failing after 41s

This is expected since the legacy package has been touched - fine to ignore.

@tombuildsstuff tombuildsstuff added this to the v3.87.0 milestone Jan 10, 2024
@tombuildsstuff tombuildsstuff merged commit 6562ad4 into main Jan 10, 2024
28 of 29 checks passed
@tombuildsstuff tombuildsstuff deleted the dependencies/go-azure-sdk branch January 10, 2024 12:15
tombuildsstuff added a commit that referenced this pull request Jan 10, 2024
@tombuildsstuff
updating to include #24453
e881cab
This was referenced Jan 22, 2024
Closed
Closed
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@catriona-m catriona-m catriona-m approved these changes

Assignees
No one assigned
Labels
dependencies service/data-protection service/disks service/maintenance service/recovery-services size/XL state-migration
Projects
None yet
Milestone
v3.87.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @catriona-m