refactor: splitting ManagedHSM out into it’s own Service Package
#24737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manicminer
approved these changes
Feb 1, 2024
internal/services/managedhsm/key_vault_managed_hardware_security_module_data_source.go
Outdated
Show resolved
Hide resolved
...l/services/managedhsm/key_vault_managed_hardware_security_module_role_assignment_resource.go
Outdated
Show resolved
Hide resolved
...vices/managedhsm/key_vault_managed_hardware_security_module_role_assignment_resource_test.go
Outdated
Show resolved
Hide resolved
...ervices/managedhsm/key_vault_managed_hardware_security_module_role_definition_data_source.go
Outdated
Show resolved
Hide resolved
Comment on lines
11
to
12
| "github.com/hashicorp/terraform-provider-azurerm/internal/services/managedhsm/parse" | ||
| "github.com/hashicorp/terraform-provider-azurerm/internal/services/managedhsm/validate" |
...vices/managedhsm/key_vault_managed_hardware_security_module_role_definition_resource_test.go
Outdated
Show resolved
Hide resolved
This commit splits Managed HSM out into it's own package to provide a logical seperation between this and Key Vault. Whilst the two services share /some/ of the same APIs, and a similar payload, the values required for these are different particularly within the Data Plane API. As such - to provide logical separation between the two and discourage code reuse to avoid subtle/hard-to-diagnose issues this commit scaffolds out a Service Package for Managed HSM. Porting the existing resources over will come in a follow up commit.
…r than Key Vault / removing the unused clients
Calling out when these are Data Plane vs Resource Management so this is clearer
tombuildsstuff
force-pushed
the
refactor/managed-hsm-to-its-own-servicepackage
branch
from
4299fbf
to
496ed9a
Compare
tombuildsstuff
deleted the
refactor/managed-hsm-to-its-own-servicepackage
branch
sinbai
pushed a commit
to sinbai/terraform-provider-azurerm
that referenced
this pull request
Feb 5, 2024
…m-to-its-own-servicepackage refactor: splitting `ManagedHSM` out into it’s own Service Package
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst Key Vault and Managed HSM are similar services, they’re now different enough that we should provide logical separations within the codebase to account for that.
In that vain, this PR splits Managed HSM out into it’s own package (
managedhsm) meaning that all of that logic is grouped within that package. Doing this helps us ensure that we correctly account for the casing of constants, given this differs between Key Vault and Managed HSM - and is required in order to make the casing consistent within thekeyvaultpackage (and migrate that to the newer API version2023-07-01, which useshashicorp/go-azure-sdks base layer).This means that PRs such as #24209 can be scoped to the Managed HSM service - meaning that we won’t unintentionally automatically supporting Managed HSM where a resource only expects Key Vault support.