Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_mssql_managed_instance : support new property azure_active_directory_administrator #24801

Merged
merged 7 commits into from
Jan 8, 2025
Merged

azurerm_mssql_managed_instance : support new property azure_active_directory_administrator #24801

merged 7 commits into from
Jan 8, 2025

Conversation

sinbai
Copy link
Contributor

@sinbai sinbai commented Feb 7, 2024 •
edited by rcskosir
Loading

Test results:
https://hashicorp.teamcity.com/buildConfiguration/TF_AzureRM_AZURERM_SERVICE_PUBLIC_MSSQLMANAGEDINSTANCE/113037?buildTab=tests

Fix #17601.

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

@sinbai sinbai force-pushed the mssqlManagedInstance/support_azuread_administrator branch 2 times, most recently from 2ed8741 to 8019c64 Compare February 22, 2024 03:43
@sinbai sinbai force-pushed the mssqlManagedInstance/support_azuread_administrator branch from e90841b to d115c7e Compare March 1, 2024 07:12
@sinbai sinbai changed the title azurerm_mssql_managed_instance : support new property azuread_administrator azurerm_mssql_managed_instance : support new property microsoft_entra_administrator Mar 1, 2024
@sinbai sinbai force-pushed the mssqlManagedInstance/support_azuread_administrator branch 4 times, most recently from cde2ae0 to b612842 Compare March 5, 2024 10:30
@sinbai sinbai marked this pull request as ready for review March 6, 2024 02:09
@nathanblair nathanblair mentioned this pull request Mar 7, 2024
Closed
1 task
@sinbai sinbai force-pushed the mssqlManagedInstance/support_azuread_administrator branch from 92fbd12 to 08c3af2 Compare December 18, 2024 08:48
@sinbai sinbai force-pushed the mssqlManagedInstance/support_azuread_administrator branch from 08c3af2 to 0ed9f48 Compare December 18, 2024 08:54
@katbyte katbyte assigned catriona-m and unassigned sinbai Dec 26, 2024
@MonzThomas
Copy link

Hi there, is there any more traction on this?

catriona-m
catriona-m approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting back the remaining comments @sinbai - LGTM!

@catriona-m catriona-m dismissed stale reviews from katbyte and jackofallops January 8, 2025 17:27

comments addressed

@catriona-m catriona-m merged commit 50a2d7d into hashicorp:main Jan 8, 2025
34 checks passed
catriona-m added a commit that referenced this pull request Jan 8, 2025
@catriona-m
Update CHANGELOG.md #24801
afdd8b2
jackofallops pushed a commit that referenced this pull request Jan 10, 2025
@catriona-m @jackofallops
Update CHANGELOG.md #24801
4c42c6c
jackofallops added a commit that referenced this pull request Jan 10, 2025
@jackofallops @stephybun
@catriona-m @wyattfry @sreallymatt @mbfrahry @katbyte
CHANGELOG for v4.15.0 release (#28276)
1756d4c 
* Update CHANGELOG.md for #28233

* Update for #28215

* Update CHANGELOG.md for #28279

* Update CHANGELOG.md #28269

* Update CHANGELOG.md #27876

* Update CHANGELOG.md #28069

* Update CHANGELOG.md for #28312

* Update CHANGELOG.md for #28278

* Update CHANGELOG.md #28311

* Update CHANGELOG.md undo 28311

* Update CHANGELOG.md #27874

* Update CHANGELOG.md

* Update CHANGELOG for #28352

* Update CHANGELOG.md for #28390

* Update CHANGELOG.md for #28398

* Update CHANGELOG.md for #28425

* Update CHANGELOG.md #28427

* Update CHANGELOG.md #28280

* Update CHANGELOG.md for #28319

* Update CHANGELOG.md #24801

* Update for #28360 #28216 #27830 #28404 #27401 #27122 #27931 #28442

* Update for #28379

* Update CHANGELOG.md for #28281

* Update for #28380

* Update for #27375

* Update for #25695

* Update CHANGELOG.md #27985

* Update CHANGELOG.md - update release date manually until can be scripted

* Update CHANGELOG.md revert date change as script available

* pre-release script updates

---------

Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com>
Co-authored-by: Wyatt Fry <wyattfry@gmail.com>
Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com>
Co-authored-by: Matthew Frahry <mbfrahry@gmail.com>
Co-authored-by: kt <kt@katbyte.me>
NotTheEvilOne pushed a commit to b1-systems/terraform-provider-azurerm that referenced this pull request Jan 20, 2025
@sinbai @NotTheEvilOne
azurerm_mssql_managed_instance : support new property `azure_active…
6591f0f 
…_directory_administrator` (hashicorp#24801)

* support new property azuread_administrator

* fix comments

* fix comments

* fix conflicts

* fix comments

* update code

* fix test
NotTheEvilOne pushed a commit to b1-systems/terraform-provider-azurerm that referenced this pull request Jan 20, 2025
@jackofallops @stephybun
@catriona-m @wyattfry @sreallymatt @mbfrahry @katbyte @NotTheEvilOne
CHANGELOG for v4.15.0 release (hashicorp#28276)
c351fd6 
* Update CHANGELOG.md for hashicorp#28233

* Update for hashicorp#28215

* Update CHANGELOG.md for hashicorp#28279

* Update CHANGELOG.md hashicorp#28269

* Update CHANGELOG.md hashicorp#27876

* Update CHANGELOG.md hashicorp#28069

* Update CHANGELOG.md for hashicorp#28312

* Update CHANGELOG.md for hashicorp#28278

* Update CHANGELOG.md hashicorp#28311

* Update CHANGELOG.md undo 28311

* Update CHANGELOG.md hashicorp#27874

* Update CHANGELOG.md

* Update CHANGELOG for hashicorp#28352

* Update CHANGELOG.md for hashicorp#28390

* Update CHANGELOG.md for hashicorp#28398

* Update CHANGELOG.md for hashicorp#28425

* Update CHANGELOG.md hashicorp#28427

* Update CHANGELOG.md hashicorp#28280

* Update CHANGELOG.md for hashicorp#28319

* Update CHANGELOG.md hashicorp#24801

* Update for hashicorp#28360 hashicorp#28216 hashicorp#27830 hashicorp#28404 hashicorp#27401 hashicorp#27122 hashicorp#27931 hashicorp#28442

* Update for hashicorp#28379

* Update CHANGELOG.md for hashicorp#28281

* Update for hashicorp#28380

* Update for hashicorp#27375

* Update for hashicorp#25695

* Update CHANGELOG.md hashicorp#27985

* Update CHANGELOG.md - update release date manually until can be scripted

* Update CHANGELOG.md revert date change as script available

* pre-release script updates

---------

Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com>
Co-authored-by: Wyatt Fry <wyattfry@gmail.com>
Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com>
Co-authored-by: Matthew Frahry <mbfrahry@gmail.com>
Co-authored-by: kt <kt@katbyte.me>
@djr747 djr747 mentioned this pull request Jan 27, 2025
Open
1 task
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff left review comments

@katbyte katbyte katbyte left review comments

@manicminer manicminer manicminer requested changes

@catriona-m catriona-m catriona-m approved these changes

@jackofallops jackofallops jackofallops left review comments

Assignees

@catriona-m catriona-m

Labels
dependencies documentation enhancement service/analysis service/api-management service/app-service service/attestation service/automation service/batch service/cdn service/cognitive-services service/connections service/container-apps service/cosmosdb service/data-factory service/data-protection service/databox-edge service/databricks service/digital-twins service/dns service/elastic service/event-grid EventGrid service/event-hubs EventHubs service/fabric service/firewall service/hdinsight service/hybrid-compute service/iot-central service/iot-hub service/key-vault Key Vault service/kusto service/load-balancers service/log-analytics service/logic service/machine-learning service/managed-apps service/managed-hsm service/management-groups service/mongo-cluster service/mssql Microsoft SQL Server service/mssqlmanagedinstance service/netapp service/network service/network-function service/nginx service/orbital service/postgresql service/power-bi service/redis service/search service/security-center service/sentinel service/service-bus service/spring service/storage service/synapse service/systemcentervirtualmachinemanager service/vmware service/workloads size/XL state-migration tooling upstream/microsoft/blocking-api-issue This label is applicable when there is a bug on the Azure API that is blocking.
Projects
None yet
Milestone
Blocked
Development

Successfully merging this pull request may close these issues.

Support for azurerm_mssql_managed_instance with AAD admin + azuread_authentication_only