New Resource: `azurerm_system_center_virtual_machine_manager_cloud` #25429

neil-yechenwei · 2024-03-27T07:31:20Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

This PR is to support new resource System Center Virtual Machine Manager Cloud in SCVMM RP. Maybe these three PRs (#25449, #25451, #25429) need to be merged one by one.

Change Log

azurerm_system_center_virtual_machine_manager_cloud - support this new resource

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Test Result

--- PASS: TestAccSystemCenterVirtualMachineManagerCloudSequential/scvmmCloud/basic (406.70s)
--- PASS: TestAccSystemCenterVirtualMachineManagerCloudSequential/scvmmCloud/requiresImport (269.70s)
--- PASS: TestAccSystemCenterVirtualMachineManagerCloudSequential/scvmmCloud/complete (326.31s)
--- PASS: TestAccSystemCenterVirtualMachineManagerCloudSequential/scvmmCloud/update (592.14s)

References

Azure doc
REST API specs

…machinemanagercloud

rcskosir · 2024-03-27T17:22:46Z

@neil-yechenwei 👋 I know this is currently a draft, but when it is ready for review can you please add in the new PR template? The extra information in the template helps with the review process and for traceability in the future for our users about what this change did.

neil-yechenwei · 2024-03-28T01:13:31Z

Thanks for the suggestion. I updated PR description.

ms-zhenhua

Hi @neil-yechenwei,
Thanks for this PR - I've taken a look through and left some comments inline. If we can fix those up, this should be good to go 👍

...es/systemcentervirtualmachinemanager/system_center_virtual_machine_manager_cloud_resource.go

neil-yechenwei · 2024-04-03T08:52:01Z

@ms-zhenhua , thanks for the comments. I updated PR. Please take another look. Thanks.

--- PASS: TestAccSystemCenterVirtualMachineManagerCloudSequential/scvmmCloud/basic (685.99s)
--- PASS: TestAccSystemCenterVirtualMachineManagerCloudSequential/scvmmCloud/requiresImport (572.06s)
--- PASS: TestAccSystemCenterVirtualMachineManagerCloudSequential/scvmmCloud/complete (278.06s)
--- PASS: TestAccSystemCenterVirtualMachineManagerCloudSequential/scvmmCloud/update (568.63s)

ms-zhenhua

@neil-yechenwei , thank you for your updates. LGTM~

neil-yechenwei · 2024-05-06T01:49:21Z

@jackofallops , thanks for the comment. Please take another look.

neil-yechenwei · 2024-05-17T05:51:37Z

Thanks for the comment. Please take another look.

…machinemanagercloud

neil-yechenwei · 2024-06-19T02:27:17Z

@katbyte , I noticed that the PR to add stateRefreshFunc has been merged. So I updated this PR to remove the time sleep accordingly. Below is the test result I just now triggered.

--- PASS: TestAccSystemCenterVirtualMachineManagerCloudSequential/scvmmCloud/basic (540.31s)
--- PASS: TestAccSystemCenterVirtualMachineManagerCloudSequential/scvmmCloud/complete (332.87s)
--- PASS: TestAccSystemCenterVirtualMachineManagerCloudSequential/scvmmCloud/requiresImport (391.18s)
--- PASS: TestAccSystemCenterVirtualMachineManagerCloudSequential/scvmmCloud/update (779.31s)

katbyte

LGTM 🌾

<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>changes detected:
	"hashicorp/azurerm" updated from "3.108.0" to "3.109.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.109.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.109.0
FEATURES:

* **New Data Source:** `azurerm_automation_runbook` ([#26359](hashicorp/terraform-provider-azurerm#26359 **New Resource:** `azurerm_data_protection_backup_instance_postgresql_flexible_server` ([#26249](hashicorp/terraform-provider-azurerm#26249 **New Resource:** `azurerm_email_communication_service_domain` ([#26179](hashicorp/terraform-provider-azurerm#26179 **New Resource:** `azurerm_system_center_virtual_machine_manager_cloud` ([#25429](hashicorp/terraform-provider-azurerm#25429 **New Resource:** `azurerm_system_center_virtual_machine_manager_virtual_machine_template` ([#25449](hashicorp/terraform-provider-azurerm#25449 **New Resource:** `azurerm_system_center_virtual_machine_manager_virtual_network` ([#25451](https://github.com/hashicorp/terraform-provider-azurerm/issues/25451))

ENHANCEMENTS:

* Data Source: `azurerm_hdinsight_cluster` - export the `cluster_id` attribute ([#26228](hashicorp/terraform-provider-azurerm#26228 `azurerm_cosmosdb_sql_container` - support for the `partition_key_kind` and `partition_key_paths` properties ([#26372](hashicorp/terraform-provider-azurerm#26372 `azurerm_data_protection_backup_instance_blob_storage` - support for the `storage_account_container_names` property ([#26232](hashicorp/terraform-provider-azurerm#26232 `azurerm_virtual_network_peering` - support for the `peer_complete_virtual_networks_enabled`, `only_ipv6_peering_enabled`, `local_subnet_names`, and `remote_subnet_names` properties ([#26229](hashicorp/terraform-provider-azurerm#26229 `azurerm_virtual_desktop_host_pool` - changing the `preferred_app_group_type` property no longer creates a new resource ([#26333](hashicorp/terraform-provider-azurerm#26333 `azurerm_maps_account` - support for the `location`, `identity`, `cors` and `data_store` properties ([#26397](https://github.com/hashicorp/terraform-provider-azurerm/issues/26397))

BUG FIXES:

* `azurerm_automation_job_schedule` - updates `azurerm_automation_job_schedule` to use a composite resource id and allows `azurerm_automation_runbook` to be updated without causing `azurerm_automation_job_schedule` to recreate ([#22164](hashicorp/terraform-provider-azurerm#22164 `azurerm_databricks_workspace`- correctly allow disabling the default firewall ([#26339](hashicorp/terraform-provider-azurerm#26339 `azurerm_virtual_hub_*` - spliting create and update so lifecycle ignore changes works correctly ([#26310](https://github.com/hashicorp/terraform-provider-azurerm/issues/26310))

DEPRECATIONS:

* Data Source: `azurerm_mariadb_server` - deprecated since the service is retiring. Please use `azurerm_mysql_flexible_server` instead ([#26354](hashicorp/terraform-provider-azurerm#26354 `azurerm_mariadb_configuration` - deprecated since the service is retiring. Please use `azurerm_mysql_flexible_server_configuration` instead ([#26354](hashicorp/terraform-provider-azurerm#26354 `azurerm_mariadb_database` - deprecated since the service is retiring. Please use `azurerm_mysql_flexible_database` instead ([#26354](hashicorp/terraform-provider-azurerm#26354 `azurerm_mariadb_firewall_rule` - deprecated since the service is retiring. Please use `azurerm_mysql_flexible_server_firewall_rule` instead ([#26354](hashicorp/terraform-provider-azurerm#26354 `azurerm_mariadb_server` - deprecated since the service is retiring. Please use `azurerm_mysql_flexible_server` instead ([#26354](hashicorp/terraform-provider-azurerm#26354 `azurerm_mariadb_virtual_network_rule` - deprecated since the service is retiring ([#26354](https://github.com/hashicorp/terraform-provider-azurerm/issues/26354))


</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/256/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>

github-actions · 2024-07-20T02:07:09Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

neil-yechenwei added 5 commits November 29, 2023 14:06

New Resource: azurerm_system_center_virtual_machine_manager_cloud

b7d20af

update code

0e4e9f8

update code

ea954d2

Merge remote-tracking branch 'upstream/main' into systemcentervirtual…

661f478

…machinemanagercloud

update code

0c7add9

github-actions bot added documentation service/systemcentervirtualmachinemanager size/XL labels Mar 27, 2024

neil-yechenwei marked this pull request as draft March 27, 2024 07:33

update code

6d0f90f

github-actions bot added the waiting-response label Mar 27, 2024

update code

71dd8e4

github-actions bot removed the waiting-response label Mar 27, 2024

update code

17f3baf

ms-zhenhua suggested changes Apr 2, 2024

View reviewed changes

github-actions bot added the waiting-response label Apr 2, 2024

update code

09eec5b

github-actions bot removed the waiting-response label Apr 3, 2024

neil-yechenwei requested a review from ms-zhenhua April 3, 2024 07:07

neil-yechenwei added 2 commits April 3, 2024 16:25

update code

5091584

update code

b152918

github-actions bot added the waiting-response label Apr 3, 2024

update code

8ada736

github-actions bot removed the waiting-response label Apr 3, 2024

ms-zhenhua approved these changes Apr 9, 2024

View reviewed changes

neil-yechenwei marked this pull request as ready for review April 9, 2024 02:23

neil-yechenwei mentioned this pull request Apr 9, 2024

New Resource: azurerm_system_center_virtual_machine_manager_virtual_machine_template #25449

Merged

4 tasks

github-actions bot added waiting-response and removed waiting-response labels Apr 25, 2024

neil-yechenwei requested a review from jackofallops May 6, 2024 01:48

github-actions bot removed the waiting-response label May 6, 2024

katbyte added the waiting-response label May 13, 2024

catriona-m added the blocked label May 13, 2024

github-actions bot removed the waiting-response label May 17, 2024

tombuildsstuff mentioned this pull request May 22, 2024

azurerm_system_center_virtual_machine_manager_server - add StateRefreshFunc for checking the sync status #26004

Merged

14 tasks

github-actions bot added the waiting-response label May 22, 2024

merge latest change

e296ee7

github-actions bot removed the waiting-response label May 28, 2024

github-actions bot added the waiting-response label Jun 13, 2024

remove time_sleep

60dfe07

github-actions bot added waiting-response and removed waiting-response labels Jun 14, 2024

neil-yechenwei added 2 commits June 14, 2024 14:42

Merge remote-tracking branch 'upstream/main' into systemcentervirtual…

1a3db07

…machinemanagercloud

merge latest change

92d6cdb

github-actions bot removed the waiting-response label Jun 14, 2024

Merge remote-tracking branch 'upstream/main' into systemcentervirtual…

1c53232

…machinemanagercloud

github-actions bot added the waiting-response label Jun 19, 2024

katbyte approved these changes Jun 19, 2024

View reviewed changes

katbyte merged commit 4d9e0e3 into hashicorp:main Jun 19, 2024
35 checks passed

github-actions bot added this to the v3.109.0 milestone Jun 19, 2024

katbyte added a commit that referenced this pull request Jun 19, 2024

Update CHANGELOG.md #25429

fc20089

github-actions bot locked as resolved and limited conversation to collaborators Jul 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: `azurerm_system_center_virtual_machine_manager_cloud` #25429

New Resource: `azurerm_system_center_virtual_machine_manager_cloud` #25429

neil-yechenwei commented Mar 27, 2024 •

edited

Loading

rcskosir commented Mar 27, 2024

neil-yechenwei commented Mar 28, 2024 •

edited

Loading

ms-zhenhua left a comment

neil-yechenwei commented Apr 3, 2024 •

edited

Loading

ms-zhenhua left a comment

neil-yechenwei commented May 6, 2024 •

edited

Loading

neil-yechenwei commented May 17, 2024 •

edited

Loading

neil-yechenwei commented Jun 19, 2024

katbyte left a comment

github-actions bot commented Jul 20, 2024

New Resource: azurerm_system_center_virtual_machine_manager_cloud #25429

New Resource: azurerm_system_center_virtual_machine_manager_cloud #25429

Conversation

neil-yechenwei commented Mar 27, 2024 • edited Loading

Community Note

Description

Change Log

Test Result

References

rcskosir commented Mar 27, 2024

neil-yechenwei commented Mar 28, 2024 • edited Loading

ms-zhenhua left a comment

Choose a reason for hiding this comment

neil-yechenwei commented Apr 3, 2024 • edited Loading

ms-zhenhua left a comment

Choose a reason for hiding this comment

neil-yechenwei commented May 6, 2024 • edited Loading

neil-yechenwei commented May 17, 2024 • edited Loading

neil-yechenwei commented Jun 19, 2024

katbyte left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 20, 2024

New Resource: `azurerm_system_center_virtual_machine_manager_cloud` #25429

New Resource: `azurerm_system_center_virtual_machine_manager_cloud` #25429

neil-yechenwei commented Mar 27, 2024 •

edited

Loading

neil-yechenwei commented Mar 28, 2024 •

edited

Loading

neil-yechenwei commented Apr 3, 2024 •

edited

Loading

neil-yechenwei commented May 6, 2024 •

edited

Loading

neil-yechenwei commented May 17, 2024 •

edited

Loading