Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix private link fast path in Express Route Connection settings #26590

Closed
wants to merge 1 commit into from

Conversation

aochsner
Copy link
Contributor

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Attempting to fix #26039

Unfortunately I'm not able to test this as I don't have an ExpressRoute connection configured in my personal Azure subscription and am not allowed to test inside my company's subscriptions where the ExpressRoutes live and we are having the same issues/workaround in the above issue.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).

Testing

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_express_route_connection - fix enablePrivateLinkFastPath json

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #26039

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aochsner, thanks for opening this PR but unfortunately, this isn't going to fix your issue. The issue is coming from what we are sending to Azure but this fix is changing something we're receiving from Azure.

@aochsner
Copy link
Contributor Author

Hey @aochsner, thanks for opening this PR but unfortunately, this isn't going to fix your issue. The issue is coming from what we are sending to Azure but this fix is changing something we're receiving from Azure.

duh sorry you're right...

@aochsner
Copy link
Contributor Author

Hey @aochsner, thanks for opening this PR but unfortunately, this isn't going to fix your issue. The issue is coming from what we are sending to Azure but this fix is changing something we're receiving from Azure.

But I'm also equally confused why it's broken...

@mbfrahry
Copy link
Member

I am as well! It's going to take some time to dig into what is happening. Did you want to keep trying or should we close this until we can dig more into it?

@stephybun
Copy link
Member

Thanks for having a go at fixing this @aochsner. A newer PR #26928 has been opened to address the same issue, since it's a more complete attempt I'm going to close this in favour of #26928.

@stephybun stephybun closed this Aug 7, 2024
Copy link

github-actions bot commented Sep 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Express route connection - InvalidJson: Could not find member enablePrivateLinkFastPath
3 participants