New Resource: `azurerm_dev_center_project_environment_type` #26941

neil-yechenwei · 2024-08-06T07:31:37Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR is to support new resource Dev Center Project Environment Type.

API Spec: https://github.com/Azure/azure-rest-api-specs/blob/c4a450f92c5a0b0cb70828d3d1588a2e690b80db/specification/devcenter/resource-manager/Microsoft.DevCenter/stable/2023-04-01/devcenter.json#L2128

Overview: https://learn.microsoft.com/en-us/azure/deployment-environments/how-to-configure-project-environment-types

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevent documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

New Resource: azurerm_dev_center_project_environment_type

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #26706

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

ms-zhenhua

Hi @neil-yechenwei ,

Thanks for this PR - I've taken a look through and left some comments inline. If we can fix those up, this should be good to go 👍

internal/services/devcenter/dev_center_project_environment_type.go

website/docs/r/dev_center_project_environment_type.html.markdown

neil-yechenwei · 2024-08-07T09:46:45Z

@ms-zhenhua , thanks for the comments. I updated PR and left suggestion. Please take another look.

neil-yechenwei · 2024-08-09T08:56:22Z

@ms-zhenhua , thanks for the comments. I updated PR. Please take another look. Below is the latest test result I just now triggered. All related test cases passed.

…ironmenttype

ms-zhenhua

Hi @neil-yechenwei ,

thank you for your updates. LGTM~

stephybun

Thanks @neil-yechenwei. Please take a look at the comments left in-line. Once those are resolved this should be good to go.

stephybun · 2024-08-13T12:29:35Z

internal/services/devcenter/dev_center_project_environment_type.go

+			properties := resp.Model
+			if properties == nil {
+				return fmt.Errorf("retrieving %s: `model` was nil", id)
+			}


In the very unlikely event that Model is returned to us as null, this should be nil checked in the Update as well. For consistency can you please update this to:

Suggested change

properties := resp.Model

if properties == nil {

return fmt.Errorf("retrieving %s: `model` was nil", id)

}

if resp.Model == nil {

return fmt.Errorf("retrieving %s: `model` was nil", id)

}

if resp.Model.Properties == nil {

return fmt.Errorf("retrieving %s: `properties` was nil", id)

}

payload := resp.Model

stephybun · 2024-08-13T12:56:50Z

internal/services/devcenter/dev_center_project_environment_type_resource_test.go

+    identity_ids = [azurerm_user_assigned_identity.test.id]
+  }
+
+  creator_role_assignment_roles = [split("/", data.azurerm_role_definition.test.id)[length(split("/", data.azurerm_role_definition.test.id)) - 1]]


I think this expression can be replaced by using the role_definition_id since that is the GUID/UUID of the role definition

Suggested change

creator_role_assignment_roles = [split("/", data.azurerm_role_definition.test.id)[length(split("/", data.azurerm_role_definition.test.id)) - 1]]

creator_role_assignment_roles = [data.azurerm_role_definition.test.role_definition_id]

The format of role_definition_id is like "/providers/Microsoft.Authorization/roleDefinitions/xxxx" but this property requires the GUID format. So I assume that we can't use role_definition_id.

stephybun · 2024-08-13T12:56:58Z

internal/services/devcenter/dev_center_project_environment_type_resource_test.go

+
+  user_role_assignment {
+    user_id = azurerm_user_assigned_identity.test.principal_id
+    roles   = [split("/", data.azurerm_role_definition.test.id)[length(split("/", data.azurerm_role_definition.test.id)) - 1]]


Same with this one

Same reason as above.

stephybun · 2024-08-13T12:57:10Z

internal/services/devcenter/dev_center_project_environment_type_resource_test.go

+  creator_role_assignment_roles = [split("/", data.azurerm_role_definition.test.id)[length(split("/", data.azurerm_role_definition.test.id)) - 1], split("/", data.azurerm_role_definition.test2.id)[length(split("/", data.azurerm_role_definition.test2.id)) - 1]]
+
+  user_role_assignment {
+    user_id = azurerm_user_assigned_identity.test.principal_id
+    roles   = [split("/", data.azurerm_role_definition.test.id)[length(split("/", data.azurerm_role_definition.test.id)) - 1], split("/", data.azurerm_role_definition.test2.id)[length(split("/", data.azurerm_role_definition.test2.id)) - 1]]
+  }
+
+  user_role_assignment {
+    user_id = azurerm_user_assigned_identity.test2.principal_id
+    roles   = [split("/", data.azurerm_role_definition.test2.id)[length(split("/", data.azurerm_role_definition.test2.id)) - 1]]
+  }


Same with these

Same reason as above.

stephybun · 2024-08-13T13:03:20Z

website/docs/r/dev_center_project_environment_type.html.markdown

+
+* `dev_center_project_id` - (Required) The ID of the associated Dev Center Project. Changing this forces a new resource to be created.
+
+* `deployment_target_id` - (Required) The ID of the subscription that the environment type will be mapped to. The environment's resources will be deployed into this subscription.


Suggested change

* `deployment_target_id` - (Required) The ID of the subscription that the environment type will be mapped to. The environment's resources will be deployed into this subscription.

* `deployment_target_id` - (Required) The ID of the subscription that the Environment Type will be mapped to. The environment's resources will be deployed into this subscription.

…ironmenttype

neil-yechenwei · 2024-08-14T02:44:51Z

@stephybun , thanks for the comments. I updated PR. Please take another look. Below is the test result I just now triggered.

stephybun

Thanks @neil-yechenwei LGTM 👍

github-actions · 2024-09-14T02:12:07Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

neil-yechenwei added 6 commits July 25, 2024 17:32

New Resource: azurerm_dev_center_project_environment_type

29ec974

add validation

df6f2a8

add tc and doc

f8c2e0e

merge latest change

91494fb

update tc

3e42196

update tc

457d49c

neil-yechenwei marked this pull request as draft August 6, 2024 07:31

github-actions bot added documentation service/dev-center size/XL labels Aug 6, 2024

neil-yechenwei added 4 commits August 6, 2024 16:25

update tc

d29dd4d

update the update func

5c5f357

change the update

4fed643

change the update

599ff44

ms-zhenhua suggested changes Aug 7, 2024

View reviewed changes

github-actions bot added the waiting-response label Aug 7, 2024

update comment

952d10f

github-actions bot removed the waiting-response label Aug 7, 2024

neil-yechenwei requested a review from ms-zhenhua August 7, 2024 09:46

github-actions bot added the waiting-response label Aug 9, 2024

remove duplicate check

5e3a6d6

github-actions bot removed the waiting-response label Aug 9, 2024

neil-yechenwei added 2 commits August 9, 2024 14:33

refine error message

00c4b66

update schema

329dc85

github-actions bot added the waiting-response label Aug 9, 2024

update schema

3e75989

github-actions bot added waiting-response and removed waiting-response labels Aug 9, 2024

format tc

d736ded

github-actions bot added waiting-response and removed waiting-response labels Aug 9, 2024

github-actions bot removed the waiting-response label Aug 9, 2024

Merge remote-tracking branch 'upstream/main' into devcenterprojectenv…

6006326

…ironmenttype

ms-zhenhua approved these changes Aug 12, 2024

View reviewed changes

neil-yechenwei marked this pull request as ready for review August 12, 2024 06:06

stephybun requested changes Aug 13, 2024

View reviewed changes

neil-yechenwei added 2 commits August 14, 2024 09:08

Merge remote-tracking branch 'upstream/main' into devcenterprojectenv…

c752cad

…ironmenttype

update md and add nil check

0ce38b6

neil-yechenwei requested a review from stephybun August 14, 2024 01:40

stephybun approved these changes Aug 14, 2024

View reviewed changes

stephybun merged commit 2f2dfdf into hashicorp:main Aug 14, 2024
34 checks passed

github-actions bot added this to the v3.116.0 milestone Aug 14, 2024

stephybun added a commit that referenced this pull request Aug 15, 2024

Update for #26863 #26941 #26928 #26878 #26254

b1d480a

github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: `azurerm_dev_center_project_environment_type` #26941

New Resource: `azurerm_dev_center_project_environment_type` #26941

neil-yechenwei commented Aug 6, 2024 •

edited

Loading

ms-zhenhua left a comment

neil-yechenwei commented Aug 7, 2024

neil-yechenwei commented Aug 9, 2024

ms-zhenhua left a comment

stephybun left a comment

stephybun Aug 13, 2024

neil-yechenwei Aug 14, 2024

stephybun Aug 13, 2024

neil-yechenwei Aug 14, 2024

stephybun Aug 13, 2024

neil-yechenwei Aug 14, 2024

stephybun Aug 13, 2024

neil-yechenwei Aug 14, 2024

stephybun Aug 13, 2024

neil-yechenwei Aug 14, 2024

neil-yechenwei commented Aug 14, 2024

stephybun left a comment

github-actions bot commented Sep 14, 2024

	creator_role_assignment_roles = [split("/", data.azurerm_role_definition.test.id)[length(split("/", data.azurerm_role_definition.test.id)) - 1]]
	creator_role_assignment_roles = [data.azurerm_role_definition.test.role_definition_id]


		* `dev_center_project_id` - (Required) The ID of the associated Dev Center Project. Changing this forces a new resource to be created.

		* `deployment_target_id` - (Required) The ID of the subscription that the environment type will be mapped to. The environment's resources will be deployed into this subscription.

New Resource: azurerm_dev_center_project_environment_type #26941

New Resource: azurerm_dev_center_project_environment_type #26941

Conversation

neil-yechenwei commented Aug 6, 2024 • edited Loading

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Related Issue(s)

ms-zhenhua left a comment

Choose a reason for hiding this comment

neil-yechenwei commented Aug 7, 2024

neil-yechenwei commented Aug 9, 2024

ms-zhenhua left a comment

Choose a reason for hiding this comment

stephybun left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

neil-yechenwei commented Aug 14, 2024

stephybun left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 14, 2024

New Resource: `azurerm_dev_center_project_environment_type` #26941

New Resource: `azurerm_dev_center_project_environment_type` #26941

neil-yechenwei commented Aug 6, 2024 •

edited

Loading