Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TestAccAzureRMRecoveryServicesProtectedVm_separateResourceGroupstest #2741

Merged
merged 2 commits into from
Jan 23, 2019

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Jan 23, 2019

No description provided.

@katbyte katbyte added this to the 1.22.0 milestone Jan 23, 2019
@katbyte katbyte requested review from tombuildsstuff and a team January 23, 2019 04:11
@ghost ghost added the size/XS label Jan 23, 2019
@katbyte
Copy link
Collaborator Author

katbyte commented Jan 23, 2019

before:

------- Stdout: -------
=== RUN   TestAccAzureRMRecoveryServicesProtectedVm_separateResourceGroups
=== PAUSE TestAccAzureRMRecoveryServicesProtectedVm_separateResourceGroups
=== CONT  TestAccAzureRMRecoveryServicesProtectedVm_separateResourceGroups
--- FAIL: TestAccAzureRMRecoveryServicesProtectedVm_separateResourceGroups (95.01s)
	testing.go:538: Step 0 error: Error applying: 1 error(s) occurred:
		
		* azurerm_storage_account.test: 1 error(s) occurred:
		
		* azurerm_storage_account.test: Error creating Azure Storage Account "acctest19011": storage.AccountsClient#Create: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status=<nil> Code="StorageAccountAlreadyExists" Message="The storage account named acctest19011 already exists under the subscription."
FAIL

after

[20:10:32] kt@snowbook:~/hashi/..3../terraform-providers/terraform-provider-azurerm▸recovery/faulty_test$ testazure TestAccAzureRMRecoveryServicesProtectedVm_separateResourceGroups
==> Fixing source code with gofmt...
# This logic should match the search logic in scripts/gofmtcheck.sh
gofmt -s -w `find . -name '*.go' | grep -v vendor`
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -test.run=TestAccAzureRMRecoveryServicesProtectedVm_separateResourceGroups -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMRecoveryServicesProtectedVm_separateResourceGroups
=== PAUSE TestAccAzureRMRecoveryServicesProtectedVm_separateResourceGroups
=== CONT  TestAccAzureRMRecoveryServicesProtectedVm_separateResourceGroups
--- PASS: TestAccAzureRMRecoveryServicesProtectedVm_separateResourceGroups (706.25s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	707.305s

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 8983a66 into master Jan 23, 2019
@tombuildsstuff tombuildsstuff deleted the recovery/faulty_test branch January 23, 2019 10:47
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants