-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce OracleDatabase ExaData Infrastructure Resource & Data #27678
Merged
stephybun
merged 53 commits into
hashicorp:main
from
eelhomsi:introduce-exa-data-and-resource
Oct 17, 2024
Merged
Introduce OracleDatabase ExaData Infrastructure Resource & Data #27678
stephybun
merged 53 commits into
hashicorp:main
from
eelhomsi:introduce-exa-data-and-resource
Oct 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…down Co-authored-by: kt <kt@katbyte.me>
…down Co-authored-by: kt <kt@katbyte.me>
…down Co-authored-by: kt <kt@katbyte.me>
… into introduce-exa-data-and-resource
…e-exa-data-and-resource
…e-exa-data-and-resource
…e-exa-data-and-resource
…e-exa-data-and-resource
…e-exa-data-and-resource
…e-exa-data-and-resource
…e-exa-data-and-resource
…e-exa-data-and-resource
… of all non ForceNew properties using the CreateOrUpdate method
…t names beginning with OFake
… into introduce-exa-data-and-resource
…e-exa-data-and-resource
stephybun
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @eelhomsi LGTM 🍀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
Introduce OracleDatabase ExaData Infrastructure Resource & Data
Most relevant changes in:
internal/services/oracledatabase/
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Testing
ExadataInfraDataSource
test:ExadataInfraResource
tests:Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
This is a (please select all that apply):
Note
If this PR changes meaningfully during the course of review please update the title and description as required.