Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_network_interface_application_security_group_association #2789

Merged
merged 3 commits into from
Jan 29, 2019

Conversation

tombuildsstuff
Copy link
Contributor

This PR introduces a new resource which associations Network Interfaces to Application Security Groups. At this time this association needs to be configured both on the azurerm_network_interface resource and using the azurerm_network_interface_application_security_group_association resource.

Come 2.0 the existing application_security_group_ids field in the azurerm_network_interface resource will be removed (as will the other deprecated fields) and the azurerm_network_interface_application_security_group_association resource will be the only way to configure these. Whilst this isn't ideal from a UX perspective in the short-term it mirrors the other fields, which ensures the UX is the same for all the fields.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor Author

Ignoring a couple of intermittent test failures the tests pass:

screenshot 2019-01-29 at 08 48 16

@tombuildsstuff tombuildsstuff merged commit 317ceba into master Jan 29, 2019
@tombuildsstuff tombuildsstuff deleted the f/nic-appsecurity branch January 29, 2019 08:49
tombuildsstuff added a commit that referenced this pull request Jan 29, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants