azurerm_network_function_collector_policy - convert source_resource_ids to a set to prevent ordering issues

[stephybun]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Technically a breaking change and users will need to recreate the resource when upgrading, but at the moment Terraform keeps trying to force recreation for any resources with more than one entry in source_resource_ids

Testing

Local run of the complete test passes

=== RUN   TestAccNetworkFunctionCollectorPolicy
--- PASS: TestAccNetworkFunctionCollectorPolicy (1062.21s)
=== RUN   TestAccNetworkFunctionCollectorPolicy/Resource
    --- PASS: TestAccNetworkFunctionCollectorPolicy/Resource (1062.21s)
=== RUN   TestAccNetworkFunctionCollectorPolicy/Resource/complete
        --- PASS: TestAccNetworkFunctionCollectorPolicy/Resource/complete (1062.21s)
PASS

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_network_function_collector_policy - convert ipfx_ingestion.source_resource_ids to a set to prevent re-ordering [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[jackofallops]

Thanks @stephybun - As discussed offline, despite this being a breaking change, this should be very low impact change and users with multiple entries will have to be currently using ignore_changes for this to be functioning, provided tests are passing it LGTM 👍