azurerm_role_definition: ability to lookup by name

[katbyte]

fixes #2784

Also deprecates azurerm_builtin_role_definition as azurerm_role_definition supersedes it.

[katbyte]

tests:

[16:02:23] kt@snowbook:~/hashi/..3../terraform-providers/terraform-provider-azurerm▸roledef/data_by_name$ testazure TestAccDataSourceAzureRMRoleDefinition
==> Fixing source code with gofmt...
# This logic should match the search logic in scripts/gofmtcheck.sh
gofmt -s -w `find . -name '*.go' | grep -v vendor`
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -test.run=TestAccDataSourceAzureRMRoleDefinition -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataSourceAzureRMRoleDefinition_basic
=== PAUSE TestAccDataSourceAzureRMRoleDefinition_basic
=== RUN   TestAccDataSourceAzureRMRoleDefinition_basicByName
=== PAUSE TestAccDataSourceAzureRMRoleDefinition_basicByName
=== RUN   TestAccDataSourceAzureRMRoleDefinition_builtIn_contributor
=== PAUSE TestAccDataSourceAzureRMRoleDefinition_builtIn_contributor
=== RUN   TestAccDataSourceAzureRMRoleDefinition_builtIn_owner
=== PAUSE TestAccDataSourceAzureRMRoleDefinition_builtIn_owner
=== RUN   TestAccDataSourceAzureRMRoleDefinition_builtIn_reader
=== PAUSE TestAccDataSourceAzureRMRoleDefinition_builtIn_reader
=== RUN   TestAccDataSourceAzureRMRoleDefinition_builtIn_virtualMachineContributor
=== PAUSE TestAccDataSourceAzureRMRoleDefinition_builtIn_virtualMachineContributor
=== CONT  TestAccDataSourceAzureRMRoleDefinition_basic
=== CONT  TestAccDataSourceAzureRMRoleDefinition_builtIn_reader
=== CONT  TestAccDataSourceAzureRMRoleDefinition_builtIn_contributor
=== CONT  TestAccDataSourceAzureRMRoleDefinition_builtIn_owner
=== CONT  TestAccDataSourceAzureRMRoleDefinition_basicByName
=== CONT  TestAccDataSourceAzureRMRoleDefinition_builtIn_virtualMachineContributor
--- PASS: TestAccDataSourceAzureRMRoleDefinition_builtIn_virtualMachineContributor (27.18s)
--- PASS: TestAccDataSourceAzureRMRoleDefinition_builtIn_contributor (27.25s)
--- PASS: TestAccDataSourceAzureRMRoleDefinition_builtIn_owner (27.51s)
--- PASS: TestAccDataSourceAzureRMRoleDefinition_builtIn_reader (27.90s)
--- PASS: TestAccDataSourceAzureRMRoleDefinition_basic (35.63s)
--- PASS: TestAccDataSourceAzureRMRoleDefinition_basicByName (36.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	36.146s
[16:03:18] kt@snowbook:~/hashi/..3../terraform-providers/terraform-provider-azurerm▸roledef/data_by_name$

[tombuildsstuff]

A couple of minor comments but this otherwise LGTM 👍

[tombuildsstuff]

(Pushed a commit to fix those minor comments)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!