Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement:] azurerm_cdn_frontdoor_profile - add support for the identity property #28068

Closed
wants to merge 10 commits into from

Conversation

WodansSon
Copy link
Collaborator

@WodansSon WodansSon commented Nov 19, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

The purpose for this PR are as follows:

  • Upgrade the AFD Profile API to the 2024-02-01 API version
  • Expose the identity field in the resource

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

image

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

ENHANCEMENTS:

  • cdn - upgrade api version to 2024-02-01 for the AFD Profile resource [GH-00000]
  • azurerm_cdn_frontdoor_profile - add support for the identity property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #20289

Related PR(s)

Depends on #28211
Depends on #28233

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@WodansSon WodansSon changed the title azurerm_cdn_frontdoor_profile - Upgrade AFD Profile API to 2024-02-01 and expose identity field azurerm_cdn_frontdoor_profile - add support for the identity property Nov 20, 2024
@WodansSon WodansSon marked this pull request as ready for review November 20, 2024 19:36
@WodansSon WodansSon modified the milestones: v4.12.0, v4.13.0 Nov 29, 2024
@WodansSon WodansSon marked this pull request as draft December 5, 2024 08:01
@WodansSon WodansSon removed this from the v4.13.0 milestone Dec 5, 2024
@WodansSon WodansSon added the upstream/pandora This issue/PR has a dependency on an issue in `github.com/hashicorp/pandora` label Dec 7, 2024
@WodansSon WodansSon changed the title azurerm_cdn_frontdoor_profile - add support for the identity property [Enhancement:] azurerm_cdn_frontdoor_profile - add support for the identity property Dec 7, 2024
@WodansSon WodansSon closed this Dec 13, 2024
@WodansSon WodansSon deleted the e_frontdoor_identity branch December 13, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies documentation enhancement service/cdn size/XL upstream/pandora This issue/PR has a dependency on an issue in `github.com/hashicorp/pandora`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_cdn_frontdoor_profile - missing identity settings
1 participant