Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_mssql_elasticpool - lower case family name in look up for sku and capacities validation #28178

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

stephybun
Copy link
Member

@stephybun stephybun commented Dec 4, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Currently users are unable to create an mssql elasticpool resource in the Hyperscale sku and PRMS family because the provider always returns a validation error. The max allowed gb value is always set to zero because we're unable to find PRMS (which is lower cased for the comparison) in the validation look up that occurs.

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_mssql_elasticpool - fix validation for Hyperscale skus and PRMS family [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@stephybun stephybun requested a review from a team as a code owner December 4, 2024 15:00
@stephybun stephybun force-pushed the b/mssql-elasticpool-sku-capacity-check branch from 8d77006 to fb5943c Compare December 5, 2024 06:51
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephybun LGTM!

@stephybun stephybun merged commit fba5bd5 into main Dec 5, 2024
30 checks passed
@stephybun stephybun deleted the b/mssql-elasticpool-sku-capacity-check branch December 5, 2024 14:29
@github-actions github-actions bot added this to the v4.13.0 milestone Dec 5, 2024
stephybun added a commit that referenced this pull request Dec 5, 2024
katbyte added a commit that referenced this pull request Dec 6, 2024
* update for #28158, #28025

* Update CHANGELOG.md #28123

* Update CHANGELOG.md #28105

* Update for #28177

* Update for #28171

* Update for #28178

* Update CHANGELOG.md

---------

Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com>
Co-authored-by: kt <kt@katbyte.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants