Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Upgrade Postgresql API version from 2023-06-01-preview/2022-12-01 to 2024-08-01" #28467

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Revert "Upgrade Postgresql API version from 2023-06-01-preview/2022-12-01 to 2024-08-01" #28467

merged 1 commit into from
Jan 9, 2025

Conversation

jackofallops
Copy link
Member

Reverts #28380

compilation errors:

Error: ../services/postgres/postgresql_flexible_server_resource.go:597:24: cannot use identity (variable of type *identity.UserAssignedMap) as *"github.com/hashicorp/go-azure-sdk/resource-manager/postgresql/2024-08-01/servers".UserAssignedIdentity value in assignment
Error: ../services/postgres/postgresql_flexible_server_resource.go:714:53: cannot use model.Identity (variable of type *"github.com/hashicorp/go-azure-sdk/resource-manager/postgresql/2024-08-01/servers".UserAssignedIdentity) as *identity.UserAssignedMap value in argument to identity.FlattenUserAssignedMap
Error: ../services/postgres/postgresql_flexible_server_resource.go:904:25: cannot use identity (variable of type *identity.UserAssignedMap) as *"github.com/hashicorp/go-azure-sdk/resource-manager/postgresql/2024-08-01/servers".UserAssignedIdentity value in assignment

@jackofallops jackofallops requested a review from a team as a code owner January 9, 2025 16:44
katbyte
katbyte approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🛋️

@jackofallops jackofallops merged commit f1c5f20 into main Jan 9, 2025
31 checks passed
@jackofallops jackofallops deleted the revert-28380-upgradepostgresqlfsadmin20240801 branch January 9, 2025 16:55
@github-actions github-actions bot added this to the v4.15.0 milestone Jan 9, 2025
NotTheEvilOne pushed a commit to b1-systems/terraform-provider-azurerm that referenced this pull request Jan 20, 2025
@jackofallops @NotTheEvilOne
Revert "Upgrade Postgresql API version from `2023-06-01-preview/2022-…
3b8303a 
…12-01` to `2024-08-01`" (hashicorp#28467)

This reverts commit 8fe05cc.
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
dependencies service/postgresql size/XL
Projects
None yet
Milestone
v4.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jackofallops @katbyte