Allow 0 capacity for servicebus

[hbuckle]

Allow the capacity to be set to 0 for service bus namespace. This is so we can create a module with the option for the premium sku - currently we have to maintain 2 modules.

Example module

variable "sku" {
  default = "Basic"
}

variable "capacity" {
  default = 0
}

resource "azurerm_servicebus_namespace" "test" {
  name                = "name"
  location            = "${azurerm_resource_group.test.location}"
  resource_group_name = "${azurerm_resource_group.test.name}"
  sku                 = "${var.sku}"
  capacity            = "${var.capacity}"
}

Usage

module "servicebusbasic" {
  sku = "Basic"
}

module "servicebuspremium" {
  sku      = "Premium"
  capacity = 4
}

[katbyte]

Hi @hbuckle,

Thank you for this PR, however as i understand it 0 is not a valid value for capacity?

Would it not be possible to default to 1 (the basic sku capacity) instead of 0?

[hbuckle]

@katbyte technically you can only set capacity for the premium sku and it has to be 1,2,4
The API will accept 0 for basic or standard but it has no effect - so this is kind of a workaround but it enables the scenario outlined above to have a single module that supports multiple skus

[katbyte]

@hbuckle,

Tried setting a basic SKU to 1 and see what your saying now, API just sets it to a 0. Could we put the validation back in and instead have it enforce 0 for basic and 1,2,4 for the premium SKUs? As well as adding a note to the documentation stating this too.

[tombuildsstuff]

LGTM 👍

[tombuildsstuff]

@katbyte

Could we put the validation back in and instead have it enforce 0 for basic and 1,2,4 for the premium SKUs? As well as adding a note to the documentation stating this too.

Taking a look through I believe this is now covered, since the validation method only allows the 4 possible values (0, 1, 2 and 4) and the Create method validates it's either 0 or not - as such I think this is fine? 👍

[hbuckle]

Correct, the validation has moved to create and should only allow 0 for non-premium skus

[tombuildsstuff]

hey @hbuckle

Thanks for pushing those changes - this now LGTM 👍

Thanks!

[tombuildsstuff]

Tests pass:

[ghost]

This has been released in version 1.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.23.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!