New Resource: azurerm_api_management_logger

[JunyiYi]

A simple resource based on azurerm_api_management service. It manages the loggers inside that service.

Several points to mention

1. I use Update() instead of CreateOrUpdate() because IsBuffered could only be updated by Update().
2. LoggerType is not updatable, thus I mark both eventhub and application_insights as ForceNew.
3. Properties under eventhub and application_insights are updatable through Credentials, however.

One of work items for #1177.

[tombuildsstuff]

hi @JunyiYi

Thanks for this PR - apologies for the delayed review here!

I've taken a look through and left some comments inline but this otherwise LGTM - if we can fix those up then this should be good to merge 👍

Thanks!

[tombuildsstuff]

hey @JunyiYi

Thanks for pushing those changes - I've taken another look through and this mostly LGTM; if we can fix up the remaining comments this otherwise should be good to merge 👍

[tombuildsstuff]

Thanks for pushing those changes @JunyiYi - this now LGTM 👍

[tombuildsstuff]

Tests pass:

[ghost]

This has been released in version 1.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.24.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!