-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource_arm_application_gateway: add exclusion configuration for waf… #3391
resource_arm_application_gateway: add exclusion configuration for waf… #3391
Conversation
08843f6
to
6a46ac1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bs-matil, things look good here too and the changes I'm requesting are very similar to the other review I did on the other application gateway PR you submitted.
… methods for exclusions, doc fixes, additional test steps
@mbfrahry I submitted fixes for "all" issues. Please review again. |
Thanks @bs-matil! The conflicts just need to be resolved from between this and your other PR |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
This PR adds an
exclusion
block to thewaf_configuration
this enables the user to set exclusions from WAF scanning.