Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_arm_application_gateway: add exclusion configuration for waf… #3391

Conversation

bs-matil
Copy link
Contributor

@bs-matil bs-matil commented May 7, 2019

This PR adds an exclusion block to the waf_configuration this enables the user to set exclusions from WAF scanning.

@bs-matil bs-matil force-pushed the upstream/application-gateway-advanced-waf-configuration-exclusions branch from 08843f6 to 6a46ac1 Compare May 7, 2019 12:39
@mbfrahry mbfrahry self-assigned this May 7, 2019
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bs-matil, things look good here too and the changes I'm requesting are very similar to the other review I did on the other application gateway PR you submitted.

… methods for exclusions, doc fixes, additional test steps
@ghost ghost added size/XL and removed size/L labels May 8, 2019
@bs-matil
Copy link
Contributor Author

bs-matil commented May 8, 2019

@mbfrahry I submitted fixes for "all" issues. Please review again.

@mbfrahry
Copy link
Member

mbfrahry commented May 9, 2019

Thanks @bs-matil! The conflicts just need to be resolved from between this and your other PR

@bs-matil
Copy link
Contributor Author

bs-matil commented May 9, 2019

@mbfrahry closed in favor of #3407

@bs-matil bs-matil closed this May 9, 2019
@ghost
Copy link

ghost commented Jun 8, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants