Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_hdinsight_*: fix endless password diff #4387

Closed
wants to merge 3 commits into from

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Sep 19, 2019

No description provided.

@katbyte katbyte added this to the v1.35.0 milestone Sep 19, 2019
@katbyte katbyte requested a review from a team September 19, 2019 18:26
@ghost ghost added the size/XS label Sep 19, 2019
@ghost ghost added size/M and removed size/XS labels Sep 19, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one 🤔 but this otherwise LGTM 👍

if v, exists := input["restAuthCredential.password"]; exists && v != nil {
password = *v
if v, ok := d.GetOk("gateway.0.password"); ok {
password = v.(string)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this won't be available at import time (and thus'll be empty, which won't be captured during a test) does this require a new resource after importing/a state migration?

@tombuildsstuff
Copy link
Contributor

Closing in favour of #4489

@tombuildsstuff tombuildsstuff deleted the hdi/gateway_password branch October 3, 2019 04:35
@ghost
Copy link

ghost commented Oct 29, 2019

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

@ghost ghost removed the waiting-response label Oct 29, 2019
@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants