azurerm_function_app - add support for the always_on and connection_string fields

[cloudify]

Hello @tombuildsstuff,

my attempt to fix #691, I've added the always_on attribute for now, if my approach is good for you I'll add the rest,

thanks

[cloudify]

I've added also the support for custom connection_string in function_app

[tombuildsstuff]

Hey @cloudify

Thanks for this PR - I've taken a look through and left a couple of comments in-line but this otherwise LGTM :)

Thanks!

[tombuildsstuff]

since this object is actually being returned, rather than mapping each individual object across can we assign the existing AppSettings object to the returned siteConfig object (for instance):

siteConfig := expandFunctionAppSiteConfig(d)
siteConfig.AppSettings = basicAppSettings

# ...

siteEnvelope := web.Site{
  # ...
  Enabled:    utils.Bool(enabled),
  SiteConfig: &siteConfig,
}

[cloudify]

done

[tombuildsstuff]

can we add an additional test to set an app setting, then enable always on (as a separate step) and then add a connection string to have an end-to-end test? Multiple test steps can be achieved by specifying multiple steps below, like so:

Steps: []resource.TestStep{
  {
    Config: config,
    Check: resource.ComposeTestCheckFunc(
      testCheckAzureRMFunctionAppExists(resourceName),
      resource.TestCheckResourceAttr(resourceName, "site_config.0.always_on", "true"),
    ),
  },
  {
    Config: updatedConfig,
    Check: resource.ComposeTestCheckFunc(
      testCheckAzureRMFunctionAppExists(resourceName),
      resource.TestCheckResourceAttr(resourceName, "site_config.0.always_on", "false"),
    ),
  },
},

[cloudify]

done

[cloudify]

@tombuildsstuff I've fixed the conflict and taken care of your suggestions

[tombuildsstuff]

Hey @cloudify

Thanks for pushing those updates - apologies for the delayed re-review here, I'm just taking a look into this now.

Thanks!

[tombuildsstuff]

hey @cloudify

Thanks for pushing those updates - I'll kick off the test suite now - but this now LGTM 👍

Thanks!

[tombuildsstuff]

Tests pass:

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!