Set ip address on public_ip regardless of dns settings. #772
Conversation
hashicorp/terraform-provider-azurerm#772 Signed-off-by: Genevieve LEsperance <glesperance@pivotal.io>
There was a problem hiding this comment.
hey @genevieve
Thanks for this PR (apologies for the delay in reviewing/merging this) - it looks good to me 👍
Thanks!
…property is set This currently fails against the `master` branch: ``` $ acctests azurerm TestAccAzureRMPublicIpStatic_basic === RUN TestAccAzureRMPublicIpStatic_basic --- FAIL: TestAccAzureRMPublicIpStatic_basic (70.86s) testing.go:459: Step 0 error: Check failed: Check 2/3 error: azurerm_public_ip.test: Attribute 'ip_address' expected to be set FAIL exit status 1 FAIL github.com/terraform-providers/terraform-provider-azurerm/azurerm 70.886s ``` But will pass once #772 is merged: ``` $ acctests azurerm TestAccAzureRMPublicIpStatic_basic === RUN TestAccAzureRMPublicIpStatic_basic --- PASS: TestAccAzureRMPublicIpStatic_basic (83.19s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 83.219s ```
|
hey @genevieve Thanks again for this PR - I've tried pushing a commit to add an acceptance test to ensure this issue is caught in future (as suggested by @TheLinuxNinja in #771 (comment)), however I don't have permissions to push this to your fork. So that we can get this in - I've opened #789 which includes the acceptance test, which we'll merge after this PR has been merged in. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
#771 (comment)