-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add forward_to property to servicebus subscription resource #861
Changes from 2 commits
a057d19
fab2e91
c3cbd7c
a69a28c
d0acd0c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -173,9 +173,18 @@ resource "azurerm_servicebus_subscription" "test" { | |
namespace_name = "${azurerm_servicebus_namespace.test.name}" | ||
topic_name = "${azurerm_servicebus_topic.test.name}" | ||
resource_group_name = "${azurerm_resource_group.test.name}" | ||
forward_to = "${azurerm_servicebus_topic.forward_to.name}" | ||
max_delivery_count = 10 | ||
} | ||
`, rInt, location, rInt, rInt, rInt) | ||
|
||
resource "azurerm_servicebus_topic" "forward_to" { | ||
name = "acctestservicebustopic-forward_to-%d" | ||
namespace_name = "${azurerm_servicebus_namespace.test.name}" | ||
resource_group_name = "${azurerm_resource_group.test.name}" | ||
} | ||
|
||
|
||
`, rInt, location, rInt, rInt, rInt, rInt) | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we make a specific test for forward to, since it's an optional field? we tend to use |
||
|
||
func testAccAzureRMServiceBusSubscription_update(rInt int, location string) string { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -98,6 +98,9 @@ The following arguments are supported: | |
supports the concept of a session. Defaults to false. Changing this forces a | ||
new resource to be created. | ||
|
||
* `forward_to` - (Optional) The name of a Queue or Topic to automatically forward | ||
messages to. Defaults to none. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can remove the |
||
|
||
### TimeSpan Format | ||
|
||
Some arguments for this resource are required in the TimeSpan format which is | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed on Slack, we don't generally specify the description for schema fields in the Azure Provider - we may in the future when there's a value for it (but there's no harm in leaving this in 😄)