Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update virtual_machine.license_type docs #970

Merged
merged 1 commit into from
Mar 13, 2018

Conversation

sigv
Copy link
Contributor

@sigv sigv commented Mar 13, 2018

The documentation for VM's license_type should mention Windows_Client and not only Windows_Server as there was a change back in #212 which dealt with this. The MS docs are pretty clear on the allowed values as well.

This follows up hashicorp#212
where the `license_type` was expanded to also allow `Windows_Client`
to be configured as the license along with `Windows_Server`,
aligning with the official MS documentation as can be seen on
https://docs.microsoft.com/en-us/rest/api/compute/virtualmachines/createorupdate#Request_Body
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this!

@tombuildsstuff tombuildsstuff merged commit 9a70621 into hashicorp:master Mar 13, 2018
@sigv sigv deleted the docs/license_type_client branch March 13, 2018 13:26
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants