Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] new binding rule type "node" #217

Closed
wolfmd opened this issue Aug 14, 2020 · 3 comments · Fixed by #218
Closed

[Feature] new binding rule type "node" #217

wolfmd opened this issue Aug 14, 2020 · 3 comments · Fixed by #218

Comments

@wolfmd
Copy link

wolfmd commented Aug 14, 2020

Terraform Version

Terraform v0.13.0, provider.consul v2.9.0

Affected Resource(s)

consul_acl_binding_rule

Enhancement
Support for NodeIdentities GH-7970 was added in consul 1.8.1.

As a part of applying NodeIdentities to a login token, a binding rule needs to have the type of "node" in order to match the node against a NodeIdentity. In the CLI this can be achieved through the following command

consul acl binding-rule create -method=some-jwt -bind-type=node -bind-name='agent-${value.nodename}'

Currently in terraform the following error is received on trying to create a binding rule with the node bind type

Error: expected bind_type to be one of [service role], got node

  on main.tf line 80, in resource "consul_acl_binding_rule" "agent_binding":
  80: resource "consul_acl_binding_rule" "agent_binding" {

It'd be great if we could support this as a valid value to be passed into terraform.

remilapeyre added a commit to remilapeyre/terraform-provider-consul that referenced this issue Aug 14, 2020
@remilapeyre
Copy link
Contributor

Hi @wolfmd, thanks for reporting this. It was a mistake to validate the type in the provider, #218 remove this and let Consul return an error if the type is not correct.

@wolfmd
Copy link
Author

wolfmd commented Aug 14, 2020

Great! Thank you for the super quick response

@wolfmd
Copy link
Author

wolfmd commented Sep 1, 2020

Any idea when this might be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants