Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: Add acceptance tests for write-only attributes #293

Open
wants to merge 55 commits into
base: main
Choose a base branch
from
Open

all: Add acceptance tests for write-only attributes #293

wants to merge 55 commits into from
+5,993 −41

Conversation

austinvalle
Copy link
Member

@austinvalle austinvalle commented Jan 10, 2025 •
edited
Loading

This PR contains new tests for write-only attributes, which are now available in Terraform v1.11.0 and the latest provider SDKs

The SDKv2 + Framework tests cover:

  • Retrieving write-only values and ensuring providers are unable to send write-only data back to Terraform
    • Trying to cover the different type/attribute combinations (blocks, nested, collections, etc.)
  • Performing validation and plan modification logic on write-only attributes

The Protocol (terraform-plugin-go) tests cover:

  • Testing Terraform's new data rules for write-only attributes in all RPCs that have state values returned
  • Testing Terraform's new data rules for write-only attributes when indicating the legacy type system (SDKv2) is used (only Plan + Apply)

SBGoods and others added 30 commits November 26, 2024 15:56
@SBGoods
Add SDKv2 resource with write-only attribute and tests
4ee9165
@austinvalle
Merge branch 'main' into SBGoods/write-only-testing
cc9487d
@austinvalle
updated go mod
699359a
@austinvalle
add some initial smoke tests for write-only framework
ef84121
@austinvalle
simplify w/o tests
4d3ff45
@austinvalle
some SDKv2 happy path tests
2f731d9
@austinvalle
add double nested set
5fe0047
@austinvalle
enforce data consistency on sdkv2 tests
c5a6557
@austinvalle
write only negative tests for SDKv2
0e9d2de
@austinvalle
Merge branch 'main' into SBGoods/write-only-testing
dd723bb
@austinvalle
verify config on update
4229766
@austinvalle
add nested attribute with write-only attr
8e9d941
@austinvalle
remove unused schema attribute
b73b034
@austinvalle
remove unused provider attribute
e08f258
@austinvalle
diff
b9c211d
@austinvalle
refactor test to avoid paths
ffa3961
@austinvalle
add negative tests for framework providers w/ old terraform versions
200d66f
@austinvalle
testing version from pkg
a75e3da
@austinvalle
write-once resource
05cdb67
@austinvalle
more SDKv2 tests with validations
6f7403d
@austinvalle
testing state nulling for fw providers
1e5bb88
@austinvalle
add write-once tests to framework providers
922e213
@austinvalle
add write-only validation tests for FW providers
3269cfa
@austinvalle
update copywrite
0b7a3de
@austinvalle
add data check tests
b30fd01
@austinvalle
move resource state test
d33be2e
@austinvalle
comment
26d1f0e
@austinvalle
upgrade resource state bugged test
ef4cd5e
@austinvalle
comment
4358d6b
@austinvalle
Merge branch 'main' into SBGoods/write-only-testing
69570b8
austinvalle
austinvalle commented Jan 10, 2025
View reviewed changes
austinvalle
austinvalle commented Jan 10, 2025
View reviewed changes
austinvalle and others added 17 commits January 14, 2025 17:19
@austinvalle
update error messages (will break CI until beta is released)
59539e8
@SBGoods
Merge branch 'refs/heads/main' into SBGoods/write-only-testing
096e585 
# Conflicts:
#	go.mod
#	go.sum
@SBGoods
Update terraform-plugin-sdk/v2 and terraform-plugin-framework dep…
6c08011 
…endencies
@SBGoods
Update tests to account for latest Core + SDK/Framework changes
ddba9e9
@SBGoods
Update tests to remove write-only set nested blocks/attributes
ac39ecd
@SBGoods
Add computed attributes to framework_writeonly resources
1d2778a
@SBGoods
Merge branch 'main' into SBGoods/write-only-testing
b1d8583 
# Conflicts:
#	go.mod
#	go.sum
@SBGoods
Update terraform-plugin-testing dependency
9c22a20
@SBGoods
Update ExpectError regex
d9e8528
@SBGoods
Merge branch 'main' into SBGoods/write-only-testing
16a7fcc 
# Conflicts:
#	go.mod
#	go.sum
@austinvalle
remove testing version constant for now
df9f33e
@austinvalle
Merge branch 'main' into SBGoods/write-only-testing
7d7d419
@austinvalle
bring back new go mod updates
4c25ed5
@austinvalle
clean up the main.go
bd0ac79
@austinvalle
remove blank space lol
083bb58
@austinvalle
diff
363407d
@austinvalle
add new validator for w/o attributes
7eb7da8
@austinvalle austinvalle marked this pull request as ready for review March 4, 2025 21:37
@austinvalle austinvalle requested a review from a team as a code owner March 4, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@austinvalle @SBGoods