Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set master_authorized_networks_config.enabled=true ... #1604

Conversation

modular-magician
Copy link
Collaborator

…when there is a master_authorized_networks_config block in terraform-google-conversion. This aligns with how terraform-google-provider handles master_authorized_networks_config block. https://github.com/GoogleCloudPlatform/magic-modules/blob/435551bdd45b3d70d145125edae1c6a0dac3517b/third_party/terraform/resources/resource_container_cluster.go.erb#L2400-L2407

Release Note Template for Downstream PRs (will be copied)

terraform-google-conversion only: set master_authorized_networks_config.enabled to true when there is a master_authorized_networks_config block in Terraform configuration.

Derived from GoogleCloudPlatform/magic-modules#2939

chrisst and others added 11 commits January 6, 2020 15:51
Signed-off-by: Modular Magician <magic-modules@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Dana Hoffman <danahoffman@google.com>
…icorp#1586)

Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Dana Hoffman <danahoffman@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Riley Karson <rileykarson@google.com>
…p#1588)

Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: emily <emilyye@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Martin Nowak <code@dawg.eu>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Brian Hildebrandt <brian3.14159@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit e587732 into hashicorp:downstream-master Jan 8, 2020
@modular-magician modular-magician deleted the downstream-pr-988be6ed6221958bfc511623ad33eb8935ca1c08 branch November 16, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants