Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iam files with snakecase back to camelcase #3972

Conversation

modular-magician
Copy link
Collaborator

In previous PR GoogleCloudPlatform/magic-modules#5594, it turns asset name from camel case to snake case, which is incorrect for a few resources including private ca pool. This PR reverts that and add a handwritten file for servicemanagent service iam.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#5605

* Fix iam files with snakecase back to camelcase

* Modify servicemanagement terraform yaml import format

* Modify servicemanagement api yaml service name to snake case

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 4d9c9d3 into hashicorp:master Jan 10, 2022
@modular-magician modular-magician deleted the downstream-pr-384175d7788d7aa11f8e116daf68b887085fc849 branch November 16, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant