Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Network Firewall Policy Rule (global and region) from DCL to MMv1 #8412

Conversation

modular-magician
Copy link
Collaborator

Hello folks.

This PR is to move two Network Firewall Policy Rule resources (global and region) from DCL to MMv1.

  • google_compute_network_firewall_policy_rule
  • google_compute_region_network_firewall_policy_rule

And this PR includes:

  • Creation of the resource on MMv1.
  • Creation of the examples and tests.
  • Remove references to DCL resource.

Note: This PR doesn't include the actual deletion of the DCL resource.

Related to hashicorp/terraform-provider-google#18134

Release Note Template for Downstream PRs (will be copied)

compute: `google_compute_network_firewall_policy_rule` now uses MMv1 engine instead of DCL.
compute: `google_compute_region_network_firewall_policy_rule` now uses MMv1 engine instead of DCL.

Derived from GoogleCloudPlatform/magic-modules#11368

…MMv1 (#11368)

Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>

[upstream:dfda8410197ea7c788909e5987067e25e938be9b]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit afaa01a into hashicorp:main Oct 15, 2024
4 checks passed
@modular-magician modular-magician deleted the downstream-pr-dfda8410197ea7c788909e5987067e25e938be9b branch November 16, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant