Remove references to deleted compute images in multiple tests #8508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upstream:cdd858547166aefcd00e45d209f6b31d63d569dc] Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
deleted the
downstream-pr-cdd858547166aefcd00e45d209f6b31d63d569dc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple tests that refer to preconfigured images in the
bosh-gce-raw-stemcellsstorage bucket. That bucket was deleted recently, so the tests began failing. That bucket was at least five years old and we never controlled it (boshis a Cloud Foundry tool), so it was bound to happen.Replacing the missing bucket with another preconfigured bucket will just kick the can down the road, so the tests are updated to no longer require one. There's three different fixes applied in this PR:
google_compute_imageresource was removed. These are tests that are not testinggoogle_compute_imageat all (and were likely copied and pasted from other tests that do).raw-disk-image.tar.gzfile, which is a valid but small disk image (it's mostly zeros so it compresses down to about 3KB). The tests using this method are replicating their earlier behavior, but without the preconfigured bucket.google_compute_imagereferences that disk. This is a bit slower than the second method but doesn't rely on a test fixture so the tests can continue to be generated.Fixes hashicorp/terraform-provider-google#19885
Fixes hashicorp/terraform-provider-google#19729
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#12062